feat(jest): Add ./global-types as an alias to ./index

[qnighy]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: chore: migrate jest-cli to TypeScript jestjs/jest#8024
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

---

Starting from jest v24.3.0, the jest package provides its own type definition.
@types/jest now serves a different purpose than that; it declares global variables injeced by jest, rather than jest's own API.

Unfortunately, that led to types: ["jest"] being resolved to the jest package, causing problems when typeRoots is configured. (example repository)

This file enables users to specify types: ["jest/global-types"] in tsconfig.json to clarify their intention.

[typescript-bot]

@qnighy Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• jest on npm, on unpkg
  • Config files to check:
    • jest/tslint.json: not the expected form and not moving towards it

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ✅ No merge conflicts
• ❌ Continuous integration tests have failed
• 🕐 A DT maintainer needs to approve changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 51587,
  "author": "qnighy",
  "headCommitOid": "614b1fd722239dbcc99d3e8223f2bd79fd0a502c",
  "lastPushDate": "2021-03-07T04:23:50.000Z",
  "lastActivityDate": "2021-03-07T04:23:50.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "jest",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest/global-types.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jest/test/global-types-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/jest/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/jest/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) and not moving towards it"
        }
      ],
      "owners": [
        "NoHomey",
        "jwbay",
        "asvetliakov",
        "alexjoverm",
        "epicallan",
        "ikatyang",
        "wsmd",
        "JamieMason",
        "douglasduteil",
        "ahnpnl",
        "joshuakgoldberg",
        "UselessPickles",
        "r3nya",
        "hotell",
        "sebald",
        "andys8",
        "antoinebrault",
        "gstamac",
        "ExE-Boss",
        "quassnoi",
        "Belco90",
        "tonyhallett",
        "ycmjason",
        "devanshj",
        "pawfa",
        "regevbr",
        "gerkindev"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "ExE-Boss",
      "date": "2021-03-06T09:55:15.000Z",
      "abbrOid": "bc106a5"
    }
  ],
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/614b1fd722239dbcc99d3e8223f2bd79fd0a502c/checks?check_suite_id=2196263734"
}

[typescript-bot]

🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr @GerkinDev — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#51587	diff
Batch compilation
Memory usage (MiB)	89.0	90.0	+1.2%
Type count	15483	15488	0%
Assignability cache size	5055	5057	0%
Language service
Samples taken	2612	2612	0%
Identifiers in tests	2612	2615	0%
getCompletionsAtPosition
Mean duration (ms)	433.5	436.6	+0.7%
Mean CV	6.8%	6.5%
Worst duration (ms)	600.6	646.9	+7.7%
Worst identifier	toBe	toBe
getQuickInfoAtPosition
Mean duration (ms)	436.4	440.6	+0.9%
Mean CV	7.4%	7.3%
Worst duration (ms)	575.6	612.2	+6.4%
Worst identifier	expect	callback

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[ExE-Boss]

import "./index" doesn’t work in JavaScript: #43315

[ExE-Boss]

Suggested change

	import "./index";
	/// <reference path="./index.d.ts"/>

[ExE-Boss]

Suggested change

	import "./global-types";
	/// <reference types="jest/global-types.d.ts"/>

[ExE-Boss]

Suggested change

global-types.d.ts

[ExE-Boss]

Suggested change

	"index.d.ts",
	"jest-tests.ts"
	"jest-tests.ts",
	"test/global-types-tests.ts"
	"jest-tests.ts",
	"test/global-types.ts",
	"index.d.ts"

[typescript-bot]

@qnighy One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

@qnighy The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

@qnighy I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Apr 6th (in a week) if the issues aren't addressed.

[typescript-bot]

@qnighy To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!