Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serverless): add variablesResolutionMode property #51615

Merged

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Mar 7, 2021

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes:
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@elibarzilay I missed this one in #51130 😅

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #51615 diff
Batch compilation
Memory usage (MiB) 44.3 44.4 +0.3%
Type count 3281 3284 0%
Assignability cache size 335 335 0%
Language service
Samples taken 591 592 0%
Identifiers in tests 591 592 0%
getCompletionsAtPosition
    Mean duration (ms) 99.3 98.9 -0.4%
    Mean CV 13.0% 12.3%
    Worst duration (ms) 131.2 141.1 +7.5%
    Worst identifier inputPath Type
getQuickInfoAtPosition
    Mean duration (ms) 94.5 95.2 +0.7%
    Mean CV 12.3% 12.5%
    Worst duration (ms) 160.4 143.7 -10.4%
    Worst identifier events events

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Mar 7, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Mar 7, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 7, 2021

@G-Rath Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 18 days — it is still unreviewed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 51615,
  "author": "G-Rath",
  "headCommitOid": "bf09dfa73781ca407730bb4a6e5f12e3855c523d",
  "lastPushDate": "2021-03-07T18:32:27.000Z",
  "lastActivityDate": "2021-03-07T18:37:03.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "serverless",
      "kind": "edit",
      "files": [
        {
          "path": "types/serverless/plugins/aws/provider/awsProvider.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/serverless/serverless-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "hassankhan",
        "JonathanWilbur",
        "a-pavlenko",
        "fredericbarthelet",
        "bryan-hunter",
        "thomasaribart"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @hassankhan @JonathanWilbur @a-pavlenko @fredericbarthelet @bryan-hunter @ThomasAribart — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Mar 18, 2021
@typescript-bot
Copy link
Contributor

Re-ping @hassankhan, @JonathanWilbur, @a-pavlenko, @fredericbarthelet, @bryan-hunter, @ThomasAribart:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Mar 25, 2021
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @G-Rath.

(Ping @hassankhan, @JonathanWilbur, @a-pavlenko, @fredericbarthelet, @bryan-hunter, @ThomasAribart.)

@sandersn sandersn merged commit 5384839 into DefinitelyTyped:master Mar 25, 2021
@typescript-bot typescript-bot removed this from Needs Maintainer Action in New Pull Request Status Board Mar 25, 2021
@typescript-bot
Copy link
Contributor

I just published @types/serverless@1.78.23 to npm.

@G-Rath G-Rath deleted the serverless-update-types-again branch April 1, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants