New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(serverless): add variablesResolutionMode
property
#51615
fix(serverless): add variablesResolutionMode
property
#51615
Conversation
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@G-Rath Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 18 days — it is still unreviewed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 51615,
"author": "G-Rath",
"headCommitOid": "bf09dfa73781ca407730bb4a6e5f12e3855c523d",
"lastPushDate": "2021-03-07T18:32:27.000Z",
"lastActivityDate": "2021-03-07T18:37:03.000Z",
"maintainerBlessed": false,
"hasMergeConflict": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "serverless",
"kind": "edit",
"files": [
{
"path": "types/serverless/plugins/aws/provider/awsProvider.d.ts",
"kind": "definition"
},
{
"path": "types/serverless/serverless-tests.ts",
"kind": "test"
}
],
"owners": [
"hassankhan",
"JonathanWilbur",
"a-pavlenko",
"fredericbarthelet",
"bryan-hunter",
"thomasaribart"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"ciResult": "pass"
} |
🔔 @hassankhan @JonathanWilbur @a-pavlenko @fredericbarthelet @bryan-hunter @ThomasAribart — please review this PR in the next few days. Be sure to explicitly select |
Re-ping @hassankhan, @JonathanWilbur, @a-pavlenko, @fredericbarthelet, @bryan-hunter, @ThomasAribart: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @G-Rath. (Ping @hassankhan, @JonathanWilbur, @a-pavlenko, @fredericbarthelet, @bryan-hunter, @ThomasAribart.) |
I just published |
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition:
@elibarzilay I missed this one in #51130 😅