[node] Fix BufferEncoding base64url option

[Timsonrobl]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

---

Fixing new base64url Buffer encoding option introduced in nodejs/node#36952 missing from type definition.

[typescript-bot]

@Timsonrobl Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• node on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 52347,
  "author": "Timsonrobl",
  "headCommitOid": "00494e8238a1dea6260b4f2b776b72ccd5663586",
  "lastPushDate": "2021-04-13T19:54:52.000Z",
  "lastActivityDate": "2021-04-15T13:34:21.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2021-04-15T02:56:21.000Z",
  "mergeRequestDate": "2021-04-15T13:34:21.000Z",
  "mergeRequestUser": "Timsonrobl",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/globals.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "brunoscheufler",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "KSXGitHub",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "nguymin4",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "Ryan-Willpower",
        "peterblazejewicz",
        "addaleax",
        "JasonHK",
        "victorperin",
        "ZYSzys"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2021-04-15T02:55:44.000Z",
      "isMaintainer": true
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @BrunoScheufler @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK @victorperin @ZYSzys — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#52347	diff
Batch compilation
Memory usage (MiB)	134.1	126.3	-5.8%
Type count	23321	23321	0%
Assignability cache size	7796	7796	0%
Language service
Samples taken	46	46	0%
Identifiers in tests	46	46	0%
getCompletionsAtPosition
Mean duration (ms)	871.9	872.0	0.0%
Mean CV	10.5%	9.3%
Worst duration (ms)	1021.7	1069.8	+4.7%
Worst identifier	a	a
getQuickInfoAtPosition
Mean duration (ms)	849.7	844.4	-0.6%
Mean CV	9.5%	9.1%
Worst duration (ms)	1038.9	972.2	-6.4%
Worst identifier	a	a

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[peterblazejewicz]

@Timsonrobl why this should be added to v13? Isn't this v15 only (current/upcoming):
https://nodejs.org/api/buffer.html#buffer_buffers_and_character_encodings

[Timsonrobl]

@Timsonrobl why this should be added to v13? Isn't this v15 only (current/upcoming):
https://nodejs.org/api/buffer.html#buffer_buffers_and_character_encodings

Definitely error on my part! Seems to be fixed now.

[peterblazejewicz]

@Timsonrobl IMO v15 is not yet a thing on DT:
#48981

[SimonSchick]

It may be wise to skip v15 (since we never got the typings in unfortunately), and focus on v16 instead.

[peterblazejewicz]

It may be wise to skip v15 (since we never got the typings in unfortunately), and focus on v16 instead.

So you mean, branch v14 as soon as v16 comes out (this month)?

[Timsonrobl]

It may be wise to skip v15 (since we never got the typings in unfortunately), and focus on v16 instead.

But if there would be conflict between v15 and v16 definitions what about people sticking with v15 as LTS release?

[SimonSchick]

Alright, I will create a barebone PR for JUST v15.0.0 which we can iterate from, should be out later today.

[Timsonrobl]

Ready to merge

[typescript-bot]

I just published @types/node@14.14.40 to npm.

[SimonSchick]

@rbuckton @Timsonrobl this shouldn't have been merged as this encoding is not available in v14, I will remove it from the v14 typings with my upcoming PR that includes 15.7 changes this appears to have already been removed, likely when I moved types to v14 folder.

While this is not a huge issue please in the future be mindful of versioning.

[Timsonrobl]

@SimonSchick Sorry, but the versioning was really confusing as same definitions were de-facto used in both v14 and v15 and since I got a go-ahead from team member I thought it was considered a lesser evil. And v14 were branched out without this change soon after, so no serious harm done, I guess.