fix(react-dom): Remove Blocking Mode

[eps1lon]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
  • Removed implementation in Remove Blocking Mode (again) facebook/react#20974
  • Removed documentation in Removed createBlockingRoot API docs and added a warning note reactjs/react.dev#3642
  • latest source: https://unpkg.com/react-dom@0.0.0-experimental-af1a4cbf7/cjs/react-dom.development.js
  • Current entrypoint for react-dom@experimental: https://github.com/facebook/react/blob/12adaffef7105e2714f82651ea51936c563fe15c/packages/react-dom/index.experimental.js#L10-L33
• [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• react-dom — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 20 days — it is still unreviewed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 52463,
  "author": "eps1lon",
  "headCommitOid": "9c2010cd1f03e3fc0c96f1186864b14ec5fc57c1",
  "lastPushDate": "2021-04-19T20:14:27.000Z",
  "lastActivityDate": "2021-04-19T20:27:42.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react-dom",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-dom/experimental.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-dom/test/experimental-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "MartynasZilinskas",
        "theruther4d",
        "Jessidhia"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @MartynasZilinskas @theruther4d @Jessidhia — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#52463	diff
Batch compilation
Memory usage (MiB)	125.1	124.5	-0.5%
Type count	28267	28261	0%
Assignability cache size	7833	7820	0%
Language service
Samples taken	438	426	-3%
Identifiers in tests	438	426	-3%
getCompletionsAtPosition
Mean duration (ms)	604.6	602.3	-0.4%
Mean CV	8.0%	8.4%
Worst duration (ms)	936.7	889.9	-5.0%
Worst identifier	element	element
getQuickInfoAtPosition
Mean duration (ms)	610.2	606.1	-0.7%
Mean CV	8.8%	8.8%
Worst duration (ms)	895.1	931.8	+4.1%
Worst identifier	createElement	createElement

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

Updated numbers for you here from a788989.

Comparison details 📊

	master	#52463	diff
Batch compilation
Memory usage (MiB)	123.8	124.1	+0.3%
Type count	28267	28261	0%
Assignability cache size	7833	7820	0%
Language service
Samples taken	438	426	-3%
Identifiers in tests	438	426	-3%
getCompletionsAtPosition
Mean duration (ms)	451.1	510.4	+13.2%
Mean CV	9.6%	19.4%
Worst duration (ms)	671.0	971.7	+44.8% 🔸
Worst identifier	element	TestComponent
getQuickInfoAtPosition
Mean duration (ms)	456.6	508.8	+11.4%
Mean CV	10.7%	19.1%
Worst duration (ms)	675.4	820.6	+21.5% 🔸
Worst identifier	createElement	scryRenderedDOMComponentsWithClass
System information
Node version	v14.16.1	v14.16.1
CPU count	2	2
CPU speed	2.593 GHz	2.593 GHz
CPU model	Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz	Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
CPU Architecture	x64	x64
Memory	6.8 GiB	6.8 GiB
Platform	linux	linux
Release	4.15.0-1111-azure	4.15.0-1113-azure

Looks like there were a couple significant differences—take a look at worst-case duration for getting completions at a position and worst-case duration for getting quick info at a position to make sure everything looks ok.

[typescript-bot]

Re-ping @MartynasZilinskas, @theruther4d, @Jessidhia:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @eps1lon.

(Ping @MartynasZilinskas, @theruther4d, @Jessidhia.)

[typescript-bot]

I just published @types/react-dom@17.0.4 to npm.