[react] flip tuple order of useTransition (experimental)

[apostolos]

Latest experimental builds have flipped the tuple order of useTransition.
Return signature is now [isPending: boolean, startTransition: function]

Relevant commit here:
facebook/react@a632f7d

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: facebook/react@a632f7d
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@apostolos Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• react — on npm, on unpkg
  • owner-approval: @eps1lon

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ❌ No merge conflicts
• ❌ Continuous integration tests have failed
• 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 52529,
  "author": "apostolos",
  "headCommitOid": "074ec9647e22958f434aecfc46a0136ef099a059",
  "lastPushDate": "2021-04-26T14:16:53.000Z",
  "lastActivityDate": "2021-05-18T18:57:05.000Z",
  "hasMergeConflict": true,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/experimental.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "digiguru",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "eps1lon",
      "date": "2021-04-26T20:11:31.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "dimitropoulos",
      "date": "2021-04-22T15:54:46.000Z",
      "abbrOid": "3e69001"
    }
  ],
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/074ec9647e22958f434aecfc46a0136ef099a059/checks?check_suite_id=2584838894"
}

[typescript-bot]

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@apostolos The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#52529	diff
Batch compilation
Memory usage (MiB)	122.0	120.9	-0.9%
Type count	35690	35690	0%
Assignability cache size	9989	9984	0%
Language service
Samples taken	2359	2359	0%
Identifiers in tests	2941	2941	0%
getCompletionsAtPosition
Mean duration (ms)	319.6	354.8	+11.0%
Mean CV	7.7%	7.7%
Worst duration (ms)	1304.4	1463.2	+12.2%
Worst identifier	props	memoized4Ref
getQuickInfoAtPosition
Mean duration (ms)	323.3	359.4	+11.2%
Mean CV	8.8%	8.7%
Worst duration (ms)	1017.7	1114.8	+9.5%
Worst identifier	x	ref
System information
Node version	v14.16.1	v14.16.1
CPU count	2	2
CPU speed	2.397 GHz	2.294 GHz
CPU model	Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture	x64	x64
Memory	6.8 GiB	6.8 GiB
Platform	linux	linux
Release	4.15.0-1111-azure	4.15.0-1113-azure

First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt.

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@apostolos Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

[typescript-bot]

@apostolos The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[damikun]

Since the pull is not finished and another already slowed this API change and is mearged (#52996) Please close this unfinished pull...

[typescript-bot]

@apostolos Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!