Don't upgrade rxjs dependents to 7

[sandersn]

rxjs@7 just shipped, and has, at least, some problems with DOM types. It also seems to only ship types to TS 4.2 and higher.

Keep its DT dependents on rxjs@6 for now.

[typescript-bot]

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

3 packages in this PR

• http-rx on npm, on unpkg
• yeoman-environment on npm, on unpkg
  • owner-approval: @manuth
• yeoman-generator on npm, on unpkg
  • owner-approval: @manuth

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 52680,
  "author": "sandersn",
  "headCommitOid": "9a5059e8cd54248bf1958ea97162e5696f89e7dc",
  "lastPushDate": "2021-04-30T17:04:37.000Z",
  "lastActivityDate": "2021-04-30T17:10:51.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "http-rx",
      "kind": "edit",
      "files": [
        {
          "path": "types/http-rx/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "L2jLiga"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "yeoman-environment",
      "kind": "edit",
      "files": [
        {
          "path": "types/yeoman-environment/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "bolasblack",
        "manuth"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "yeoman-generator",
      "kind": "edit",
      "files": [
        {
          "path": "types/yeoman-generator/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "armorik83",
        "janslow",
        "ikatyang",
        "tasadar2",
        "haggen",
        "chigix",
        "misterdev",
        "manuth"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "manuth",
      "date": "2021-04-30T17:10:51.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @L2jLiga @bolasblack @manuth @armorik83 @janslow @ikatyang @tasadar2 @haggen @chigix @misterdev — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[manuth]

Looks fine to me

[sandersn]

Yep, I'm going to merge this to keep these packages working, although it would be a good idea to make them work with rxjs@7 after it gets its types figured out.

[typescript-bot]

I just published @types/http-rx@2.0.1 to npm.

[typescript-bot]

I just published @types/yeoman-environment@2.10.3 to npm.

[typescript-bot]

I just published @types/yeoman-generator@4.11.4 to npm.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

http-rx/v2.0

	master	#52680	diff
Batch compilation
Memory usage (MiB)	87.5	92.7	+6.0%
Type count	16570	16812	+1%
Assignability cache size	3435	3305	-4%
Language service
Samples taken	40	40	0%
Identifiers in tests	40	40	0%
getCompletionsAtPosition
Mean duration (ms)	377.9	436.4	+15.5%
Mean CV	15.8%	13.0%
Worst duration (ms)	498.8	507.8	+1.8%
Worst identifier	delete	httpRx
getQuickInfoAtPosition
Mean duration (ms)	358.5	437.0	+21.9% 🔸
Mean CV	13.8%	14.1%
Worst duration (ms)	391.4	507.4	+29.6% 🔸
Worst identifier	response	Observable

Looks like there were a couple significant differences—take a look at mean duration for getting quick info at a position and worst-case duration for getting quick info at a position to make sure everything looks ok.

yeoman-environment/v2.10

Comparison details for yeoman-environment/2.10 📊

	master	#52680	diff
Batch compilation
Memory usage (MiB)	100.2	95.7	-4.5%
Type count	24136	19941	-17%
Assignability cache size	4826	4358	-10%
Language service
Samples taken	64	64	0%
Identifiers in tests	64	64	0%
getCompletionsAtPosition
Mean duration (ms)	518.1	588.5	+13.6%
Mean CV	10.7%	9.6%
Worst duration (ms)	716.1	817.2	+14.1%
Worst identifier	stdout	process
getQuickInfoAtPosition
Mean duration (ms)	520.7	589.9	+13.3%
Mean CV	11.2%	9.8%
Worst duration (ms)	722.8	793.7	+9.8%
Worst identifier	stdout	process

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

yeoman-generator/v4.11

Comparison details for yeoman-generator/4.11 📊

	master	#52680	diff
Batch compilation
Memory usage (MiB)	103.5	88.2	-14.8%
Type count	24558	20363	-17%
Assignability cache size	4776	4305	-10%
Language service
Samples taken	364	364	0%
Identifiers in tests	364	364	0%
getCompletionsAtPosition
Mean duration (ms)	575.4	560.7	-2.6%
Mean CV	7.6%	9.4%
Worst duration (ms)	723.2	708.8	-2.0%
Worst identifier	MyES2015Generator	path
getQuickInfoAtPosition
Mean duration (ms)	579.7	563.0	-2.9%
Mean CV	8.1%	8.6%
Worst duration (ms)	757.3	683.4	-9.8%
Worst identifier	registerConfigPrompts	path
System information
Node version	v14.16.1	v14.16.1
CPU count	2	2
CPU speed	2.294 GHz	2.095 GHz
CPU model	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz	Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
CPU Architecture	x64	x64
Memory	6.8 GiB	6.8 GiB
Platform	linux	linux
Release	4.15.0-1113-azure	4.15.0-1113-azure

First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt.

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.