New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint): add Context#getPhysicalFilename
method
#54419
Conversation
@JounQin Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 54419,
"author": "JounQin",
"headCommitOid": "4a6cb7d29e87446809332bce910ece7e7e13e6f7",
"lastPushDate": "2021-07-10T08:58:00.000Z",
"lastActivityDate": "2021-07-12T23:44:32.000Z",
"maintainerBlessed": "Waiting for Author to Merge",
"mergeOfferDate": "2021-07-12T22:02:19.000Z",
"mergeRequestDate": "2021-07-12T23:44:32.000Z",
"mergeRequestUser": "JounQin",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "eslint",
"kind": "edit",
"files": [
{
"path": "types/eslint/eslint-tests.ts",
"kind": "test"
},
{
"path": "types/eslint/index.d.ts",
"kind": "definition"
}
],
"owners": [
"pmdartus",
"j-f1",
"saadq",
"JasonHK",
"bradzacher",
"JounQin"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 877600832,
"ciResult": "pass"
} |
🔔 @pmdartus @j-f1 @saadq @JasonHK @bradzacher — please review this PR in the next few days. Be sure to explicitly select |
@JounQin: Everything looks good here. I am ready to merge this PR (at 4a6cb7d) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@pmdartus, @j-f1, @saadq, @JasonHK, @bradzacher: you can do this too.) |
Ready to merge |
I just published |
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should contain{ "extends": "dtslint/dt.json" }
, and no additional rules.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
getPhysicalFilename()
method to rule context (fixes #11989) eslint/eslint#14616If removing a declaration:
notNeededPackages.json
.