Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] Fix property 'detail' of PerformanceEntry #55724

Merged
merged 3 commits into from Sep 19, 2021

Conversation

cafca
Copy link
Contributor

@cafca cafca commented Sep 12, 2021

This spelling mistake in a property name has been fixed in node.js documentation per nodejs/node#40019

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

This spelling mistake in a property name has been fixed in node.js per nodejs/node#40019
@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 12, 2021

@cafca Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 5 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 55724,
  "author": "cafca",
  "headCommitOid": "1c20367e0f9b8dbc8ba68f97259613910f3cab6c",
  "lastPushDate": "2021-09-12T21:12:05.000Z",
  "lastActivityDate": "2021-09-19T08:35:52.000Z",
  "mergeOfferDate": "2021-09-13T18:23:46.000Z",
  "mergeRequestDate": "2021-09-19T08:35:52.000Z",
  "mergeRequestUser": "cafca",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/perf_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/perf_hooks.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "nguymin4",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "Ryan-Willpower",
        "peterblazejewicz",
        "addaleax",
        "JasonHK",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2021-09-13T18:23:12.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 917682153,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels Sep 12, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Sep 12, 2021
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Sep 12, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Sep 12, 2021
@typescript-bot
Copy link
Contributor

@cafca The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@cafca cafca marked this pull request as draft September 12, 2021 20:59
@cafca
Copy link
Contributor Author

cafca commented Sep 13, 2021

I think I have fixed all issues with this PR and would welcome a review.

@cafca cafca marked this pull request as ready for review September 13, 2021 07:28
@typescript-bot typescript-bot removed The CI failed When GH Actions fails Untested Change This PR does not touch tests labels Sep 13, 2021
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board Sep 13, 2021
Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@cafca thx!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Sep 13, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Sep 13, 2021
@typescript-bot
Copy link
Contributor

@cafca: Everything looks good here. I am ready to merge this PR (at 1c20367) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @nguymin4, @yoursunny, @qwelias, @ExE-Boss, @Ryan-Willpower, @peterblazejewicz, @addaleax, @JasonHK, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13: you can do this too.)

@cafca
Copy link
Contributor Author

cafca commented Sep 19, 2021

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Sep 19, 2021
@typescript-bot typescript-bot merged commit beceb9d into DefinitelyTyped:master Sep 19, 2021
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants