Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): v16.11 #56462

Merged
merged 3 commits into from Oct 14, 2021
Merged

feat(node): v16.11 #56462

merged 3 commits into from Oct 14, 2021

Conversation

panva
Copy link
Contributor

@panva panva commented Oct 12, 2021

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: nodejs/node@v16.10.0...v16.11.0
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 12, 2021

@panva Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 56462,
  "author": "panva",
  "headCommitOid": "9364324ca7b0d1e94610ba8ac17735a7348d8756",
  "lastPushDate": "2021-10-12T15:43:05.000Z",
  "lastActivityDate": "2021-10-14T17:48:34.000Z",
  "mergeOfferDate": "2021-10-14T17:48:28.000Z",
  "mergeRequestDate": "2021-10-14T17:48:34.000Z",
  "mergeRequestUser": "panva",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/diagnostics_channel.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/fs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/fs/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/fs.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/util.ts",
          "kind": "test"
        },
        {
          "path": "types/node/util.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v14/test/util.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v14/util.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "nguymin4",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "Ryan-Willpower",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "amcasey",
      "date": "2021-10-14T17:47:51.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "LinusU",
      "date": "2021-10-12T15:54:47.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "SimonSchick",
      "date": "2021-10-12T15:54:44.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 940974152,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels Oct 12, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 12, 2021
@panva
Copy link
Contributor Author

panva commented Oct 12, 2021

There's nothing to test, v16.11.0 did not change any wrt. types, only docs which is what this updates.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Oct 12, 2021
@LinusU
Copy link
Contributor

LinusU commented Oct 12, 2021

There's nothing to test, v16.11.0 did not change any wrt. types, only docs which is what this updates.

@panva I believe that 16.11.0 added e.g. stripVTControlCharacters? as can be seen in #56435

@panva
Copy link
Contributor Author

panva commented Oct 12, 2021

There's nothing to test, v16.11.0 did not change any wrt. types, only docs which is what this updates.

@panva I believe that 16.11.0 added e.g. stripVTControlCharacters? as can be seen in #56435

I'll add it then.

@typescript-bot typescript-bot removed the Untested Change This PR does not touch tests label Oct 12, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Oct 12, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Oct 12, 2021
@LinusU
Copy link
Contributor

LinusU commented Oct 12, 2021

There's nothing to test, v16.11.0 did not change any wrt. types, only docs which is what this updates.

@panva I believe that 16.11.0 added e.g. stripVTControlCharacters? as can be seen in #56435

I'll add it then.

Maybe cherry-pick the commit from that PR to this so that both changes are merged at the same time?

node 16.x
- Add `debug` alias.
- Add `getSystemErrorName`.
- Add `stripVTControlCharacters`.

node 14.x
- Add `debug` alias. Fix `debuglog` types.
- Add `getSystemErrorName`.
@panva
Copy link
Contributor Author

panva commented Oct 12, 2021

@LinusU done, #56435 can be closed in favour of this one.

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Oct 12, 2021
@LinusU
Copy link
Contributor

LinusU commented Oct 12, 2021

Nice 👍

It seems like filehandle.createReadStream and filehandle.createWriteStream was also added in 16.11, but that should be the last thing!

ref: nodejs/node#40009

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Oct 12, 2021
@panva
Copy link
Contributor Author

panva commented Oct 12, 2021

Nice 👍

It seems like filehandle.createReadStream and filehandle.createWriteStream was also added in 16.11, but that should be the last thing!

ref: nodejs/node#40009

done.

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Oct 12, 2021
Copy link
Contributor

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 👍

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Oct 12, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Oct 12, 2021
@Semigradsky Semigradsky mentioned this pull request Oct 13, 2021
8 tasks
@typescript-bot typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label Oct 14, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Oct 14, 2021
@typescript-bot
Copy link
Contributor

@panva: Everything looks good here. I am ready to merge this PR (at 9364324) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @nguymin4, @yoursunny, @qwelias, @ExE-Boss, @Ryan-Willpower, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13: you can do this too.)

@panva
Copy link
Contributor Author

panva commented Oct 14, 2021

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Oct 14, 2021
@typescript-bot typescript-bot merged commit bacc304 into DefinitelyTyped:master Oct 14, 2021
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants