Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git-clone #56873

Merged
merged 5 commits into from
Oct 31, 2021
Merged

Conversation

LinqLover
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm test <package to test>.
  • The package does not already provide its own types,
  • or cannot have its .d.ts files generated via --declaration
    • please explain
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 29, 2021

@LinqLover Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 56873,
  "author": "LinqLover",
  "headCommitOid": "39c155ab2ead541cda8a95def5b2db6f6975f78d",
  "lastPushDate": "2021-10-30T12:35:09.000Z",
  "lastActivityDate": "2021-10-31T19:15:57.000Z",
  "mergeOfferDate": "2021-10-30T20:04:20.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "git-clone",
      "kind": "add",
      "files": [
        {
          "path": "types/git-clone/git-clone-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/git-clone/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/git-clone/promise.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/git-clone/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/git-clone/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "DefinitelyTyped"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2021-10-30T20:03:41.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 955042769,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Oct 29, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 29, 2021
@typescript-bot
Copy link
Contributor

🔔 @LinqLover — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@LinqLover LinqLover mentioned this pull request Oct 29, 2021
12 tasks
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Oct 29, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Oct 29, 2021
@typescript-bot
Copy link
Contributor

@LinqLover The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Oct 29, 2021
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Oct 29, 2021
@LinqLover
Copy link
Contributor Author

@jaz303 Would you like to be co-owner for the type definitions of git-clone? :-)

🔔 @LinqLover — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Oct 29, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in New Pull Request Status Board Oct 29, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Oct 29, 2021
@typescript-bot
Copy link
Contributor

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com>
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in New Pull Request Status Board Oct 30, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Oct 30, 2021
@typescript-bot
Copy link
Contributor

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@LinqLover thx!

@typescript-bot typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label Oct 30, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Oct 30, 2021
@LinqLover
Copy link
Contributor Author

LinqLover commented Oct 30, 2021

@LinqLover: Everything looks good here. I am ready to merge this PR (at 39c155a) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

Ready to merge 🚀

@peterblazejewicz
Copy link
Member

@typescript-bot please?

@peterblazejewicz peterblazejewicz merged commit fe93f70 into DefinitelyTyped:master Oct 31, 2021
@typescript-bot typescript-bot removed this from Waiting for Author to Merge in New Pull Request Status Board Oct 31, 2021
@peterblazejewicz
Copy link
Member

Merged manually while bot was away doing 🎃

@LinqLover LinqLover deleted the add/git-clone branch October 31, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants