Fixed the electron-positioner type when a type of position is Position | TrayPosition

[ktmouk]

I'm sorry but the PR I requested was a bit incorrect.

If thetrayBounds argument is passed, no type error should occur regardless of whether the type of position is Position nor TrayPosition. But the previous PR is wasn't.

a type error has occurred.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/jenslind/electron-positioner#traybounds
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@ktmouk Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• electron-positioner — on npm, on unpkg (author is owner)

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 57385,
  "author": "ktmouk",
  "headCommitOid": "ab9ad1cfa8d56de4d303a85a8e228914b760faef",
  "lastPushDate": "2021-11-26T15:04:25.000Z",
  "lastActivityDate": "2021-12-16T02:28:06.000Z",
  "mergeOfferDate": "2021-12-15T19:11:10.000Z",
  "mergeRequestDate": "2021-12-16T02:28:06.000Z",
  "mergeRequestUser": "ktmouk",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "electron-positioner",
      "kind": "edit",
      "files": [
        {
          "path": "types/electron-positioner/electron-positioner-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/electron-positioner/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ktmouk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2021-12-15T19:10:29.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 980034652,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @ktmouk — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

[typescript-bot]

Re-ping @«anyone?»:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @ktmouk.

(Ping @«anyone?».)

[ktmouk]

@gabritto I'm sorry to trouble you, but could you review this PR?

[typescript-bot]

@ktmouk: Everything looks good here. I am ready to merge this PR (at ab9ad1c) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

[ktmouk]

Ready to merge