Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/pg] Add missing options config #58001

Merged
merged 1 commit into from Jan 10, 2022

Conversation

glentakahashi
Copy link
Contributor

This fixes a missing options config for pg

This is not in documentation, but was added in 8.3.0 via brianc/node-postgres#2216

@glentakahashi glentakahashi changed the title [@types/pg] Add options config [@types/pg] Add missing options config Jan 5, 2022
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 5, 2022

@glentakahashi Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58001,
  "author": "glentakahashi",
  "headCommitOid": "6fcd03c368f6e11c5179fb9c291c4cf944f43b24",
  "mergeBaseOid": "22439e6e9b4e57eac897a8538b80610ad950adb8",
  "lastPushDate": "2022-01-05T21:43:59.000Z",
  "lastActivityDate": "2022-01-05T21:45:53.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "pg",
      "kind": "edit",
      "files": [
        {
          "path": "types/pg/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pspeter3",
        "HoldYourWaffle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1006103832,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Jan 5, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jan 5, 2022
@typescript-bot
Copy link
Contributor

🔔 @pspeter3 @HoldYourWaffle — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jan 5, 2022
@weswigham weswigham merged commit 8d54c7e into DefinitelyTyped:master Jan 10, 2022
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jan 10, 2022
@glentakahashi glentakahashi deleted the patch-1 branch January 10, 2022 22:10
martin-badin pushed a commit to martin-badin/DefinitelyTyped that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants