Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] Support async formatters #58333

Merged
merged 1 commit into from Jan 22, 2022
Merged

[eslint] Support async formatters #58333

merged 1 commit into from Jan 22, 2022

Conversation

fasttime
Copy link
Contributor

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: feat: support async formatter eslint/eslint#15243
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Jan 20, 2022
@fasttime fasttime marked this pull request as ready for review January 20, 2022 16:29
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 20, 2022

@fasttime Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58333,
  "author": "fasttime",
  "headCommitOid": "2527c3a64e4555840e27dc9fbff7b4ce97f2285e",
  "mergeBaseOid": "486ece6b6f3067da32b23f5add67fad9b626fa02",
  "lastPushDate": "2022-01-20T12:35:05.000Z",
  "lastActivityDate": "2022-01-22T18:44:13.000Z",
  "mergeOfferDate": "2022-01-20T20:02:28.000Z",
  "mergeRequestDate": "2022-01-22T18:44:13.000Z",
  "mergeRequestUser": "fasttime",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "eslint",
      "kind": "edit",
      "files": [
        {
          "path": "types/eslint/eslint-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/eslint/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pmdartus",
        "j-f1",
        "saadq",
        "JasonHK",
        "bradzacher",
        "JounQin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-01-20T20:01:51.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "bradzacher",
      "date": "2022-01-20T18:07:28.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1017687828,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @pmdartus @j-f1 @saadq @JasonHK @bradzacher @JounQin — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board Jan 20, 2022
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jan 20, 2022
Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jan 20, 2022
@typescript-bot
Copy link
Contributor

@fasttime: Everything looks good here. I am ready to merge this PR (at 2527c3a) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@pmdartus, @j-f1, @saadq, @JasonHK, @bradzacher, @JounQin: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Jan 20, 2022
@fasttime
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jan 22, 2022
@typescript-bot typescript-bot merged commit ff28e2b into DefinitelyTyped:master Jan 22, 2022
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Jan 22, 2022
martin-badin pushed a commit to martin-badin/DefinitelyTyped that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants