Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Fix ERR_IMPORT_ASSERTION_TYPE_MISSING #58840

Merged
merged 2 commits into from Feb 18, 2022

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Feb 17, 2022

  • Importing JSON modules requires import assertion since Node.js v16.14.0
  • Set tsconfig module: "esnext" to support import assertions
  • Unrelated cosmetic changes and comment, for D3.js docs symmetry

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 17, 2022

@jablko Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58840,
  "author": "jablko",
  "headCommitOid": "b23e5d4a3ecacd1cc3bae4f1afdda248a865253c",
  "mergeBaseOid": "369ecc516615fb782639bd4d707be43a01c90df4",
  "lastPushDate": "2022-02-17T17:14:02.000Z",
  "lastActivityDate": "2022-02-18T22:05:26.000Z",
  "mergeOfferDate": "2022-02-18T17:54:44.000Z",
  "mergeRequestDate": "2022-02-18T22:05:26.000Z",
  "mergeRequestUser": "jablko",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": ".github/workflows/support-window.yml",
          "kind": "infrastructure"
        },
        {
          "path": "docs/support-window.svg",
          "kind": "infrastructure"
        },
        {
          "path": "scripts/support-window.ts",
          "kind": "infrastructure"
        },
        {
          "path": "scripts/tsconfig.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2022-02-18T17:54:07.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1043230074,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @jablko — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Feb 17, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Feb 17, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 18, 2022
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Feb 18, 2022
@typescript-bot
Copy link
Contributor

@jablko: Everything looks good here. I am ready to merge this PR (at b23e5d4) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@jablko
Copy link
Contributor Author

jablko commented Feb 18, 2022

Ready to merge! ❤️

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Feb 18, 2022
@typescript-bot typescript-bot merged commit 7e8ea8e into DefinitelyTyped:master Feb 18, 2022
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 19, 2022
martin-badin pushed a commit to martin-badin/DefinitelyTyped that referenced this pull request Feb 23, 2022
…PE_MISSING by @jablko

* [README] Fix ERR_IMPORT_ASSERTION_TYPE_MISSING

* [README] 🤖 Update support window diagram

https://github.com/jablko/DefinitelyTyped/actions/runs/1860034598

Co-authored-by: github/workflows/support-window.yml <bot@typescriptlang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants