Fix: correct Mocha overloads order #59075
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition:
[ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.Corrects function overloads for
it
and the like in Mocha so that the more specific async parameters come first per microsoft/TypeScript#48077 (comment) (thanks @MartinJohns!).I tried switching to unions but hit test errors about
this
no longer being defined: https://github.com/DefinitelyTyped/DefinitelyTyped/runs/5394917747?check_suite_focus=trueThrowing this PR up as a draft while there are test failures as reference for microsoft/TypeScript#48088.