Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[babel__traverse] Add new method hasNode() to NodePath #59355

Merged
merged 1 commit into from Apr 14, 2022
Merged

[babel__traverse] Add new method hasNode() to NodePath #59355

merged 1 commit into from Apr 14, 2022

Conversation

danez
Copy link
Contributor

@danez danez commented Mar 19, 2022

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

Some prettier style changes also sneaked in 😊

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 19, 2022

@danez Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59355,
  "author": "danez",
  "headCommitOid": "52768e27c5fab0c9823a6e163f98386cf95b892e",
  "mergeBaseOid": "f94108026f016eb99b08469b40c78fd2a9090ee2",
  "lastPushDate": "2022-03-19T18:42:55.000Z",
  "lastActivityDate": "2022-04-14T13:51:21.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2022-04-13T21:05:21.000Z",
  "mergeRequestDate": "2022-04-14T13:51:21.000Z",
  "mergeRequestUser": "danez",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "babel__traverse",
      "kind": "edit",
      "files": [
        {
          "path": "types/babel__traverse/babel__traverse-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/babel__traverse/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/babel__traverse/ts4.1/babel__traverse-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/babel__traverse/ts4.1/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "yortus",
        "marvinhagemeister",
        "rpetrich",
        "mgroenhoff",
        "dlgrit",
        "ifiokjr",
        "ExE-Boss",
        "danez"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2022-04-13T21:04:41.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1073061189,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Mar 19, 2022
@typescript-bot
Copy link
Contributor

🔔 @yortus @marvinhagemeister @rpetrich @mgroenhoff @dlgrit @ifiokjr @ExE-Boss — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Mar 19, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Mar 19, 2022
Copy link
Contributor

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to hear from an owner.

@amcasey amcasey moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Mar 23, 2022
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Mar 30, 2022
@typescript-bot
Copy link
Contributor

Re-ping @yortus, @marvinhagemeister, @rpetrich, @mgroenhoff, @dlgrit, @ifiokjr, @ExE-Boss:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @danez.

(Ping @yortus, @marvinhagemeister, @rpetrich, @mgroenhoff, @dlgrit, @ifiokjr, @ExE-Boss.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Apr 6, 2022
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type annotation matches that in the linked PR (though I do wonder why the project doesn't ship types if upstream is TS already, oh well).

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Apr 13, 2022
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Apr 13, 2022
@typescript-bot
Copy link
Contributor

@danez: Everything looks good here. I am ready to merge this PR (at 52768e2) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@yortus, @marvinhagemeister, @rpetrich, @mgroenhoff, @dlgrit, @ifiokjr, @ExE-Boss: you can do this too.)

@danez
Copy link
Contributor Author

danez commented Apr 14, 2022

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Apr 14, 2022
@typescript-bot typescript-bot merged commit 382ed20 into DefinitelyTyped:master Apr 14, 2022
@danez danez deleted the traverse_hasNode branch April 14, 2022 13:57
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants