Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-protobuf: Add isDelimited to BinaryReader #60066

Conversation

tatethurston
Copy link
Contributor

@tatethurston tatethurston commented Apr 26, 2022

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: url here

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 26, 2022

@tatethurston Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 60066,
  "author": "tatethurston",
  "headCommitOid": "f5bc4c55dfc2c8e5a28149b01d0357f5f35f6712",
  "mergeBaseOid": "75caddac0420de0f61cab44176d3901a49df10d4",
  "lastPushDate": "2022-04-26T20:36:05.000Z",
  "lastActivityDate": "2022-04-26T21:07:24.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "google-protobuf",
      "kind": "edit",
      "files": [
        {
          "path": "types/google-protobuf/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "marcuslongmuir",
        "kamthamc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "kamthamc",
      "date": "2022-04-26T21:07:24.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1110225076,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Apr 26, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Apr 26, 2022
@typescript-bot
Copy link
Contributor

🔔 @MarcusLongmuir @kamthamc — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

google-protobuf (unpkg)

was missing the following properties:

  1. exportSymbol
  2. inherits
  3. object
  4. typeOf

Generated by 🚫 dangerJS against f5bc4c5

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Apr 26, 2022
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Apr 26, 2022
@weswigham weswigham merged commit a7629d0 into DefinitelyTyped:master Apr 28, 2022
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants