Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react] Remove timeoutMs mentions from JSDoc #60567

Conversation

MysteryBlokHed
Copy link
Contributor

@MysteryBlokHed MysteryBlokHed commented May 28, 2022

Related discussion: #60564

The timeoutMs parameter doesn't exist any more as of facebook/react#19703

@typescript-bot
Copy link
Contributor

typescript-bot commented May 28, 2022

@MysteryBlokHed Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 60567,
  "author": "MysteryBlokHed",
  "headCommitOid": "14f80318afc340acde17b1fbed5b882020e4e84f",
  "mergeBaseOid": "1e22f7b70f7b671652c29a5921ed7db22ef5da85",
  "lastPushDate": "2022-05-28T14:36:51.000Z",
  "lastActivityDate": "2022-05-31T18:17:56.000Z",
  "mergeOfferDate": "2022-05-31T18:07:39.000Z",
  "mergeRequestDate": "2022-05-31T18:17:56.000Z",
  "mergeRequestUser": "MysteryBlokHed",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan",
        "priyanshurav"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2022-05-31T18:06:59.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "eps1lon",
      "date": "2022-05-28T18:47:14.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1140276707,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels May 28, 2022
@typescript-bot
Copy link
Contributor

Hey @MysteryBlokHed,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 28, 2022
@typescript-bot
Copy link
Contributor

@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react (unpkg)

was missing the following properties:

  1. unstable_act

Generated by 🚫 dangerJS against 14f8031

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 28, 2022
Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 28, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 31, 2022
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board May 31, 2022
@typescript-bot
Copy link
Contributor

@MysteryBlokHed: Everything looks good here. I am ready to merge this PR (at 14f8031) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@johnnyreilly, @bbenezech, @pzavolinsky, @ericanderson, @DovydasNavickas, @theruther4d, @guilhermehubner, @ferdaber, @jrakotoharisoa, @pascaloliv, @Hotell, @franklixuefei, @Jessidhia, @saranshkataria, @lukyth, @eps1lon, @zieka, @dancerphil, @dimitropoulos, @disjukr, @vhfmag, @hellatan, @priyanshurav: you can do this too.)

@MysteryBlokHed
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 31, 2022
@typescript-bot typescript-bot merged commit e0eb1fd into DefinitelyTyped:master May 31, 2022
@MysteryBlokHed MysteryBlokHed deleted the react/remove-timeoutms-jsdoc branch May 31, 2022 18:29
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants