fix(@jest/types): align jest v28 dependencies (requires typescript bump to v4.5)

[viceice]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@viceice Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

15 packages in this PR

• expect-puppeteer — on npm, on unpkg
• heft-jest — on npm, on unpkg
• jest-axe — on npm, on unpkg
• jest-expect-message — on npm, on unpkg
• jest-image-snapshot — on npm, on unpkg
  • owner-approval: @peterblazejewicz
• jest-in-case — on npm, on unpkg
• jest-json-schema — on npm, on unpkg
• jest-matcher-one-of — on npm, on unpkg
• jest-plugin-context — on npm, on unpkg
• jest-sinon — on npm, on unpkg
• jest-specific-snapshot — on npm, on unpkg
• jest-when — on npm, on unpkg
• jest — on npm, on unpkg
• mapbox__aws-sdk-jest — on npm, on unpkg
• testing-library__jest-dom — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 60832,
  "author": "viceice",
  "headCommitOid": "2efa3c17364f9406e7a9df910c6e1d63107f1e53",
  "mergeBaseOid": "9c58088a931fdab5737f2e1343f3946421bf0de8",
  "lastPushDate": "2022-06-16T14:02:32.000Z",
  "lastActivityDate": "2022-06-17T11:46:34.000Z",
  "mergeOfferDate": "2022-06-17T11:33:58.000Z",
  "mergeRequestDate": "2022-06-17T11:46:34.000Z",
  "mergeRequestUser": "viceice",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "expect-puppeteer",
      "kind": "edit",
      "files": [
        {
          "path": "types/expect-puppeteer/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tkrotoff",
        "jfm710"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "heft-jest",
      "kind": "edit",
      "files": [
        {
          "path": "types/heft-jest/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "octogonz",
        "iclanton"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "jest-axe",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-axe/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "erbridge"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "jest-expect-message",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-expect-message/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "mike-d-davydov",
        "saitonakamura"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "jest-image-snapshot",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-image-snapshot/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dawnmist",
        "erbridge",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "jest-in-case",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-in-case/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "geovanisouza92"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "jest-json-schema",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-json-schema/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "lvl99"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "jest-matcher-one-of",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-matcher-one-of/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "joemitchard"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "jest-plugin-context",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-plugin-context/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "jonasheinrich"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "jest-sinon",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-sinon/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "seidelmartin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "jest-specific-snapshot",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-specific-snapshot/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "dawnmist"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "jest-when",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-when/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "aldentaylor",
        "immanuel192",
        "gstamac",
        "hipsterbrown"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "jest",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jest/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "NoHomey",
        "jwbay",
        "asvetliakov",
        "alexjoverm",
        "epicallan",
        "ikatyang",
        "wsmd",
        "JamieMason",
        "douglasduteil",
        "ahnpnl",
        "UselessPickles",
        "r3nya",
        "hotell",
        "sebald",
        "andys8",
        "antoinebrault",
        "gstamac",
        "ExE-Boss",
        "quassnoi",
        "Belco90",
        "tonyhallett",
        "ycmjason",
        "pawfa",
        "regevbr",
        "gerkindev",
        "domdomegg"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "mapbox__aws-sdk-jest",
      "kind": "edit",
      "files": [
        {
          "path": "types/mapbox__aws-sdk-jest/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "stevensnoeijen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "testing-library__jest-dom",
      "kind": "edit",
      "files": [
        {
          "path": "types/testing-library__jest-dom/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "gnapse",
        "jgoz",
        "smacpherson64",
        "AndrewLeedham"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-06-17T11:32:58.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "SimenB",
      "date": "2022-06-17T11:10:26.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1157422591,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @tkrotoff @jfm710 @octogonz @iclanton @erbridge @mike-d-davydov @saitonakamura @dawnmist @peterblazejewicz @geovanisouza92 @lvl99 @joemitchard @jonasheinrich @seidelmartin @aldentaylor @immanuel192 @gstamac @HipsterBrown @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @pawfa @regevbr @GerkinDev @domdomegg @stevensnoeijen @gnapse @jgoz @smacpherson64 @AndrewLeedham — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[viceice]

This is a follow-up from #58784. If you upgrade all jest packages to v28, typescript will complain because of importing wrong jest types

[viceice]

@SimenB WDYT?

[viceice]

[11:02:17 AM] Starting compilation in watch mode...

test/util.ts:141:32 - error TS2345: Argument of type 'Plugin' is not assignable to parameter of type 'Plugin_2'.
  Type 'NewPlugin' is not assignable to type 'Plugin_2'.
    Type 'import("/home/kriese/src/renovate/node_modules/@types/jest/node_modules/pretty-format/build/types").NewPlugin' is not assignable to type 'import("/home/kriese/src/renovate/node_modules/pretty-format/build/index").NewPlugin'.
      Types of property 'serialize' are incompatible.
        Type '(val: any, config: import("/home/kriese/src/renovate/node_modules/@types/jest/node_modules/pretty-format/build/types").Config, indentation: string, depth: number, refs: import("/home/kriese/src/renovate/node_modules/@types/jest/node_modules/pretty-format/build/types").Refs, printer: import("/home/kriese/src/renovate...' is not assignable to type '(val: any, config: import("/home/kriese/src/renovate/node_modules/pretty-format/build/index").Config, indentation: string, depth: number, refs: import("/home/kriese/src/renovate/node_modules/pretty-format/build/index").Refs, printer: import("/home/kriese/src/renovate/node_modules/pretty-format/build/index").Printer)...'.
          Types of parameters 'config' and 'config' are incompatible.
            Type 'import("/home/kriese/src/renovate/node_modules/pretty-format/build/index").Config' is not assignable to type 'import("/home/kriese/src/renovate/node_modules/@types/jest/node_modules/pretty-format/build/types").Config'.
              Types of property 'plugins' are incompatible.
                Type 'import("/home/kriese/src/renovate/node_modules/pretty-format/build/index").Plugins' is not assignable to type 'import("/home/kriese/src/renovate/node_modules/@types/jest/node_modules/pretty-format/build/types").Plugins'.
                  Type 'Plugin_2' is not assignable to type 'Plugin'.
                    Type 'NewPlugin' is not assignable to type 'Plugin'.
                      Type 'import("/home/kriese/src/renovate/node_modules/pretty-format/build/index").NewPlugin' is not assignable to type 'import("/home/kriese/src/renovate/node_modules/@types/jest/node_modules/pretty-format/build/types").NewPlugin'.
                        Types of property 'serialize' are incompatible.
                          Type '(val: any, config: import("/home/kriese/src/renovate/node_modules/pretty-format/build/index").Config, indentation: string, depth: number, refs: import("/home/kriese/src/renovate/node_modules/pretty-format/build/index").Refs, printer: import("/home/kriese/src/renovate/node_modules/pretty-format/build/index").Printer)...' is not assignable to type '(val: any, config: import("/home/kriese/src/renovate/node_modules/@types/jest/node_modules/pretty-format/build/types").Config, indentation: string, depth: number, refs: import("/home/kriese/src/renovate/node_modules/@types/jest/node_modules/pretty-format/build/types").Refs, printer: import("/home/kriese/src/renovate...'.
                            Types of parameters 'config' and 'config' are incompatible.
                              Property 'maxWidth' is missing in type 'import("/home/kriese/src/renovate/node_modules/@types/jest/node_modules/pretty-format/build/types").Config' but required in type 'import("/home/kriese/src/renovate/node_modules/pretty-format/build/index").Config'.

141   expect.addSnapshotSerializer(replacingSerializer(from, to));
                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  node_modules/pretty-format/build/index.d.ts:44:3
    44   maxWidth: number;
         ~~~~~~~~
    'maxWidth' is declared here.

test/util.ts:157:32 - error TS2345: Argument of type 'Plugin' is not assignable to parameter of type 'Plugin_2'.

157   expect.addSnapshotSerializer(bufferSerializer);
                                   ~~~~~~~~~~~~~~~~

[11:02:34 AM] Found 2 errors. Watching for file changes.

• chore(deps): update jest monorepo to v28 (major) renovatebot/renovate#16103

[typescript-bot]

@viceice The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

Hey @viceice,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

@viceice The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@viceice The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@SimenB Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[peterblazejewicz]

@viceice can you edit the PR title, so it reflects TS version bump to be aligned with Jest v28 TS version? Thanks!

[typescript-bot]

@peterblazejewicz, @SimenB Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[typescript-bot]

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[peterblazejewicz]

LGTM!

[typescript-bot]

@viceice: Everything looks good here. I am ready to merge this PR (at 2efa3c1) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

[viceice]

Ready to merge