[react][react-is] Move experimental APIs to stable for React 18 #61634

steinybot · 2022-08-10T00:49:55Z

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

Provide a URL to documentation or source code which provides context for the suggested changes: <>
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

typescript-bot · 2022-08-10T00:50:42Z

@steinybot Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

2 packages in this PR

react-is — on npm, on unpkg
react — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
❌ Continuous integration tests have failed
🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 61634,
  "author": "steinybot",
  "headCommitOid": "78c95c7e1bcad744140249c4135ce5d3e791ea2f",
  "mergeBaseOid": "2d2f21e4ef13e725c7e1565fd8661d5389261c72",
  "lastPushDate": "2022-08-10T01:11:41.000Z",
  "lastActivityDate": "2022-08-10T16:21:49.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react-is",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-is/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-is/test/react-is-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-is/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/react-is/v16/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-is/v17/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-is/v17/next.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-is/v17/test/next-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-is/v17/test/react-is-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/react-is/v17/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/react-is/v17/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "AviVahl",
        "christianchown",
        "eps1lon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/experimental.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/test/experimental.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/react/test/tsx.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/v15/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v15/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/react/v16/global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v16/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v16/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/react/v17/global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v17/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/v17/test/index.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan",
        "priyanshurav"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "eps1lon",
      "date": "2022-08-10T16:21:49.000Z"
    }
  ],
  "mainBotCommentID": 1210030351,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/78c95c7e1bcad744140249c4135ce5d3e791ea2f/checks?check_suite_id=7743669136"
}

typescript-bot · 2022-08-10T00:50:44Z

🔔 @AviVahl @christianchown @eps1lon @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot · 2022-08-10T00:51:58Z

@steinybot The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2022-08-10T01:08:54Z

@steinybot The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

steinybot · 2022-08-10T01:16:03Z

types/react-is/v17/tsconfig.json

@@ -0,0 +1,31 @@
+{


I copied this from v16.

steinybot · 2022-08-10T01:16:26Z

types/react-is/v17/tsconfig.json

+        "paths": {
+            "react": ["react/v17"],
+            "react-dom": ["react-dom/v17"],
+            "react-is/*": ["react-is/v17/*"]


I don't know why this is different to v16 but I did what the build told me to do.

steinybot · 2022-08-10T01:18:24Z

types/react-is/index.d.ts

@@ -33,6 +24,7 @@ export function isProfiler(value: any): value is ReactElement;
 export function isPortal(value: any): value is ReactElement;
 export function isStrictMode(value: any): value is ReactElement;
 export function isSuspense(value: any): value is ReactElement;
+export function isSuspenseList(value: any): value is ReactElement;


Copied from types/react-is/v17/next.d.ts

steinybot · 2022-08-10T01:19:02Z

types/react-is/test/react-is-tests.tsx

+
+// SuspenseList
+ReactIs.isSuspenseList(<React.SuspenseList children={<div />} />); // true
+ReactIs.typeOf(<React.SuspenseList children={<div />} />) === ReactIs.SuspenseList; // true


Copied from types/react-is/v17/test/next-tests.tsx

steinybot · 2022-08-10T01:31:57Z

types/react/index.d.ts

-            [K in keyof JSX.IntrinsicElements]: P extends JSX.IntrinsicElements[K] ? K : never
-        }[keyof JSX.IntrinsicElements] |
-        ComponentType<P>;
+        | {


Most of this is formatting changes.

steinybot · 2022-08-10T01:32:14Z

types/react/index.d.ts

@@ -398,14 +426,70 @@ declare namespace React {
    }

    const Suspense: ExoticComponent<SuspenseProps>;
+
+    export type SuspenseListRevealOrder = 'forwards' | 'backwards' | 'together';


Copied from types/react/experimental.d.ts

steinybot · 2022-08-10T01:32:34Z

types/react/index.d.ts

    const version: string;

    /**
     * {@link https://reactjs.org/docs/profiler.html#onrender-callback Profiler API}
     */
    type ProfilerOnRenderCallback = (
        id: string,
-        phase: "mount" | "update",
+        phase: 'mount' | 'update',


Everything below is formatting.

typescript-bot · 2022-08-10T01:33:22Z

@steinybot The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

eps1lon

Can we separate this into PRs for each package to understand more what the motivation is? react-is needs a bump fro 18 as far as I understand but the changes to react seem wrong.

Also: Please file this without the formatting changes so that git-blame is unaffected. In the future this repository will be formatted automatically but until then these spurious formatting changes make reviewing needlessly hard.

eps1lon · 2022-08-10T16:20:14Z

types/react/index.d.ts

+     * @see https://reactjs.org/docs/concurrent-mode-reference.html#suspenselist
+     * @see https://reactjs.org/docs/concurrent-mode-patterns.html#suspenselist
+     */
+    export const SuspenseList: ExoticComponent<SuspenseListProps>;


SuspenseList is not part of the stable release

typescript-bot · 2022-08-10T16:22:35Z

@steinybot One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

steinybot · 2022-08-10T20:26:48Z

I thought changing react would break react-is but it is just the /// <reference that won't be 100%.

react PR here: #61649

steinybot added 3 commits August 10, 2022 12:18

Move experimental APIs to stable for React 18

a412e3a

See facebook/react#21488.

Add v17 types back in

90659d9

Fix formatting

9608219

steinybot requested review from johnnyreilly and Jessidhia as code owners August 10, 2022 00:49

typescript-bot added Critical package Edits multiple packages labels Aug 10, 2022

typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Aug 10, 2022

typescript-bot added the The CI failed When GH Actions fails label Aug 10, 2022

typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Aug 10, 2022

Fix v17 config

d81fb16

typescript-bot removed the The CI failed When GH Actions fails label Aug 10, 2022

typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Aug 10, 2022

typescript-bot added the The CI failed When GH Actions fails label Aug 10, 2022

typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Aug 10, 2022

Fix v17 path entry

78c95c7

typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR and removed The CI failed When GH Actions fails labels Aug 10, 2022

typescript-bot moved this from Needs Author Action to Other in New Pull Request Status Board Aug 10, 2022

steinybot commented Aug 10, 2022

View reviewed changes

types/react-is/v17/tsconfig.json

@@ -0,0 +1,31 @@

{

Copy link

Author

steinybot Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from v16.

steinybot commented Aug 10, 2022

View reviewed changes

typescript-bot added The CI failed When GH Actions fails and removed Where is GH Actions? GH Actions didn't give a response to this PR labels Aug 10, 2022

typescript-bot moved this from Other to Needs Author Action in New Pull Request Status Board Aug 10, 2022

eps1lon requested changes Aug 10, 2022

View reviewed changes

typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Aug 10, 2022

steinybot closed this Aug 10, 2022

typescript-bot removed this from Needs Author Action in New Pull Request Status Board Aug 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[react][react-is] Move experimental APIs to stable for React 18 #61634

[react][react-is] Move experimental APIs to stable for React 18 #61634

steinybot commented Aug 10, 2022

typescript-bot commented Aug 10, 2022 •

edited

typescript-bot commented Aug 10, 2022

typescript-bot commented Aug 10, 2022

typescript-bot commented Aug 10, 2022

steinybot Aug 10, 2022

steinybot Aug 10, 2022

steinybot Aug 10, 2022

steinybot Aug 10, 2022

steinybot Aug 10, 2022

steinybot Aug 10, 2022

steinybot Aug 10, 2022

typescript-bot commented Aug 10, 2022

eps1lon left a comment

eps1lon Aug 10, 2022

typescript-bot commented Aug 10, 2022

steinybot commented Aug 10, 2022

[react][react-is] Move experimental APIs to stable for React 18 #61634

[react][react-is] Move experimental APIs to stable for React 18 #61634

Conversation

steinybot commented Aug 10, 2022

typescript-bot commented Aug 10, 2022 • edited

2 packages in this PR

Code Reviews

Status

typescript-bot commented Aug 10, 2022

typescript-bot commented Aug 10, 2022

typescript-bot commented Aug 10, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

typescript-bot commented Aug 10, 2022

eps1lon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

typescript-bot commented Aug 10, 2022

steinybot commented Aug 10, 2022

typescript-bot commented Aug 10, 2022 •

edited