Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

three: Fix ConstructorUnion's distributivity #62011

Merged
merged 1 commit into from Aug 29, 2022

Conversation

sandersn
Copy link
Contributor

Typescript 4.9 optimises substitution types, but this exposes that ConstructorUnion isn't correctly distributive.

I used the fix suggested by @ahejlsberg on the same PR.

Typescript 4.9 [optimises substitution
types](https://github.com/microsoft/TypeScript/pull/50397a), but this
exposes that ConstructorUnion isn't correctly distributive.

I used the [fix suggested by Anders
Hejslberg](microsoft/TypeScript#50397 (comment))
on the same PR.
@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 29, 2022

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 62011,
  "author": "sandersn",
  "headCommitOid": "3a472370287de229f19b1e3c3195d235a6efd2c9",
  "mergeBaseOid": "80216bd1ac48be44ac7bbc1cc26bbab1c9cc8a91",
  "lastPushDate": "2022-08-29T17:15:50.000Z",
  "lastActivityDate": "2022-08-29T17:22:12.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "three",
      "kind": "edit",
      "files": [
        {
          "path": "types/three/examples/jsm/nodes/shadernode/ShaderNode.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "joshuaellis",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "joshuaellis",
      "date": "2022-08-29T17:18:39.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1230605458,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Aug 29, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Aug 29, 2022
@typescript-bot
Copy link
Contributor

🔔 @joshuaellis @Methuselah96 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Aug 29, 2022
@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

three (unpkg)

was missing the following properties:

  1. ColorManagement
  2. DataUtils
  3. Font
  4. FontLoader
  5. ImmediateRenderObject
as well as these 5 other properties...

LinearSRGBColorSpace, NoColorSpace, ParametricGeometry, SRGBColorSpace, TextGeometry

Generated by 🚫 dangerJS against 3a47237

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Aug 29, 2022
@sandersn sandersn merged commit 34ce0f9 into master Aug 29, 2022
@sandersn sandersn deleted the three-fix-constructionunion-distributivity branch August 29, 2022 17:26
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants