Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest] mark the expected argument of *CalledWith* matchers as optional #62572

Merged
merged 1 commit into from Oct 6, 2022
Merged

[jest] mark the expected argument of *CalledWith* matchers as optional #62572

merged 1 commit into from Oct 6, 2022

Conversation

mrazauskas
Copy link
Contributor

@mrazauskas mrazauskas commented Oct 5, 2022

Please fill in this template.

If changing an existing definition:

Summary

Similar change was made in Jest repo recently. It is based on the actual behaviour of the matchers. For the details, see the above mentioned PR.

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 5, 2022

@mrazauskas Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 62572,
  "author": "mrazauskas",
  "headCommitOid": "abfda010e4d30b0ce42008f449dddaf44705250c",
  "mergeBaseOid": "a48767353465e80b326e4dd00ad48e94bef394fb",
  "lastPushDate": "2022-10-05T16:53:16.000Z",
  "lastActivityDate": "2022-10-06T14:00:37.000Z",
  "mergeOfferDate": "2022-10-06T13:59:55.000Z",
  "mergeRequestDate": "2022-10-06T14:00:37.000Z",
  "mergeRequestUser": "mrazauskas",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "jest",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jest/jest-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "NoHomey",
        "jwbay",
        "asvetliakov",
        "alexjoverm",
        "epicallan",
        "ikatyang",
        "wsmd",
        "JamieMason",
        "douglasduteil",
        "ahnpnl",
        "UselessPickles",
        "r3nya",
        "hotell",
        "sebald",
        "andys8",
        "antoinebrault",
        "gstamac",
        "ExE-Boss",
        "quassnoi",
        "Belco90",
        "tonyhallett",
        "ycmjason",
        "pawfa",
        "gerkindev",
        "domdomegg"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2022-10-06T13:59:07.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "domdomegg",
      "date": "2022-10-05T20:34:49.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1268691332,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR Critical package labels Oct 5, 2022
@typescript-bot
Copy link
Contributor

🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @pawfa @GerkinDev @domdomegg — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@mrazauskas mrazauskas changed the title [jest] mark the argument of *CalledWith* matchers as optional [jest] mark the expected argument of *CalledWith* matchers as optional Oct 5, 2022
@typescript-bot typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label Oct 5, 2022
@typescript-bot typescript-bot moved this from Other to Needs Maintainer Review in New Pull Request Status Board Oct 5, 2022
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Oct 5, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 6, 2022
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Oct 6, 2022
@typescript-bot
Copy link
Contributor

@mrazauskas: Everything looks good here. I am ready to merge this PR (at abfda01) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@NoHomey, @jwbay, @asvetliakov, @alexjoverm, @epicallan, @ikatyang, @wsmd, @JamieMason, @douglasduteil, @ahnpnl, @UselessPickles, @r3nya, @Hotell, @sebald, @andys8, @antoinebrault, @gstamac, @ExE-Boss, @quassnoi, @Belco90, @tonyhallett, @ycmjason, @pawfa, @GerkinDev, @domdomegg: you can do this too.)

@mrazauskas
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Oct 6, 2022
@typescript-bot typescript-bot merged commit 0a09449 into DefinitelyTyped:master Oct 6, 2022
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 15, 2023
@mrazauskas mrazauskas deleted the jest-ReturnedWith-arg-type branch April 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants