[node] fix: stream depends on global Blob not available in v16

[meyfa]

Blob is only available on the global object starting in Node 18. Still, the stream definitions used the global Blob. This means that @types/node 16.x is currently broken. This patch adds the correct import to resolve this problem. For more info please refer to #62654.

Long-term, IMHO we should remove "lib": ["dom"] from the v16 TSConfig like it was already done for v18, but I'd much rather get this fix out quickly and worry about that later.

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
  • I made a local repro of the problem (see [node] Add type side of global Blob, along with tests #62654 (comment)), and after editing node_modules/@types/node/ts4.8/stream.d.ts the problem went away.
• Add or edit tests to reflect the change.
  • Don't know how to test this. I think it should be fine once we remove "lib": ["dom"] from the v16 TSConfig, since TypeScript would then complain if using global Blob anywhere.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
  • [node] Add type side of global Blob, along with tests #62654 (comment)
  • global Blob in Node.js 18: https://nodejs.org/docs/latest-v18.x/api/globals.html#class-blob
  • no global Blob in Node.js 16: https://nodejs.org/docs/latest-v16.x/api/globals.html#class-blob
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@meyfa Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• node — on npm, on unpkg
  • owner-approval: @r3nya, @peterblazejewicz

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 62672,
  "author": "meyfa",
  "headCommitOid": "d9ac31cbf15251eb4dbb40524caf5b7c598a83bf",
  "mergeBaseOid": "ae199c4d1ac55cbc848449934d3cc59bc3ea9918",
  "lastPushDate": "2022-10-12T12:07:01.000Z",
  "lastActivityDate": "2022-10-15T21:04:45.000Z",
  "mergeOfferDate": "2022-10-15T21:03:13.000Z",
  "mergeRequestDate": "2022-10-15T21:04:45.000Z",
  "mergeRequestUser": "meyfa",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/v16/stream.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/ts4.8/stream.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "r3nya",
      "date": "2022-10-15T21:04:16.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-10-15T21:02:25.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "G-Rath",
      "date": "2022-10-14T23:06:32.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1276061011,
  "ciResult": "pass"
}

[typescript-bot]

Hey @meyfa,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[pluma]

Oh dear, yes please. This just broke our CI (but it's a good way to find out our CI ignores lockfiles).

[meyfa]

CC @peterblazejewicz Sorry to bother you, but could you perhaps take a look at this? Node v16 types are broken without this change.

[peterblazejewicz]

@meyfa thanks!

[typescript-bot]

@meyfa: Everything looks good here. I am ready to merge this PR (at d9ac31c) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina: you can do this too.)

[meyfa]

Ready to merge