[node:test] Update types

[shockerqt]

• test, describe and it return Promise<void>
• The callback for the 3 functions can by sync or async
• describe callback takes SuiteContext as its only argument
• Added SuiteContext class definition

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>

[typescript-bot]

@shockerqt Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• node — on npm, on unpkg
  • owner-approval: @peterblazejewicz, @Semigradsky

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 65871,
  "author": "shockerqt",
  "headCommitOid": "8eee8abd49405a0a2122b8837eb38909c5ffbbe7",
  "mergeBaseOid": "1e1904e2588afe22d759094c21b90eac9caec018",
  "lastPushDate": "2023-06-25T20:37:58.000Z",
  "lastActivityDate": "2023-07-07T22:34:47.000Z",
  "mergeOfferDate": "2023-07-07T20:53:06.000Z",
  "mergeRequestDate": "2023-07-07T22:34:47.000Z",
  "mergeRequestUser": "shockerqt",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/test.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2023-07-07T20:52:20.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Semigradsky",
      "date": "2023-07-07T07:34:01.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "SimonSchick",
      "date": "2023-06-25T23:39:23.000Z",
      "abbrOid": "446d9a8"
    }
  ],
  "mainBotCommentID": 1606255777,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[SimonSchick]

Some of those type changes appear to be incorrect based on local testing, please test individual variants before continuing.

[typescript-bot]

@shockerqt One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[shockerqt]

Some of those type changes appear to be incorrect based on local testing, please test individual variants before continuing.

Right! I was expecting test({ todo: true }) and todo() to return the same, since the first returns Promise<void>.

[typescript-bot]

@SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[Semigradsky]

Some of those type changes appear to be incorrect based on local testing, please test individual variants before continuing.

Right! I was expecting test({ todo: true }) and todo() to return the same, since the first returns Promise<void>.

I expect the same, it can be a bug in Node.js, would be nice to open an issue in https://github.com/nodejs/node

UPD: I have created nodejs/node#48557

[RyanCavanaugh]

What's the status here? The .d.ts and node were both wrong, or the .d.ts was right and node was wrong?

[shockerqt]

What's the status here? The .d.ts and node were both wrong, or the .d.ts was right and node was wrong?

Both are wrong, the last commit I pushed should be the correct .d.ts in the current node version.
And if this PR is accepted my second commit should be the correct.

I think we should fix the types for the current state of node for now

[Semigradsky]

@shockerqt return type was fixed in v20.4.0. Please remove the last commit and rebase from master

[typescript-bot]

Re-ping @microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[shockerqt]

I removed the last commit

[peterblazejewicz]

LGTM!
@shockerqt thanks!

[typescript-bot]

@shockerqt: Everything looks good here. I am ready to merge this PR (at 8eee8ab) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.)

[shockerqt]

Ready to merge