-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toHaveAccessibleErrorMessage
to @testing-library/jest-dom
Types
#66089
Add toHaveAccessibleErrorMessage
to @testing-library/jest-dom
Types
#66089
Conversation
ec4bf62
to
9c32d6e
Compare
@ITenthusiasm Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66089,
"author": "ITenthusiasm",
"headCommitOid": "f58e2d708e347d4c167a2288d66cb1a75971a08f",
"mergeBaseOid": "b0312dc15a45f047f9ad907cc9b32ea4d91c9037",
"lastPushDate": "2023-07-18T01:38:50.000Z",
"lastActivityDate": "2023-07-24T20:36:55.000Z",
"mergeOfferDate": "2023-07-24T20:32:40.000Z",
"mergeRequestDate": "2023-07-24T20:36:55.000Z",
"mergeRequestUser": "ITenthusiasm",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "testing-library__jest-dom",
"kind": "edit",
"files": [
{
"path": "types/testing-library__jest-dom/index.d.ts",
"kind": "definition"
},
{
"path": "types/testing-library__jest-dom/matchers.d.ts",
"kind": "definition"
},
{
"path": "types/testing-library__jest-dom/test/testing-library__jest-dom-extend-matchers-tests.ts",
"kind": "test"
}
],
"owners": [
"gnapse",
"jgoz",
"smacpherson64",
"AndrewLeedham"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2023-07-24T20:31:58.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "gnapse",
"date": "2023-07-18T19:44:44.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "AndrewLeedham",
"date": "2023-07-18T13:06:38.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1640102152,
"ciResult": "pass"
} |
🔔 @gnapse @jgoz @smacpherson64 @AndrewLeedham — please review this PR in the next few days. Be sure to explicitly select |
Created in response to (and thus depends on): - testing-library/jest-dom#503
9c32d6e
to
f58e2d7
Compare
@gnapse Updated the |
@gnapse Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Ready to merge |
Thanks all! |
Will circle back to the checklist tomorrow.Created in response to (and thus depends on):
toHaveErrorMessage
to Spec and Rename totoHaveAccessibleErrorMessage
testing-library/jest-dom#503Please fill in this template.
npm test <package to test>
.If changing an existing definition:
(Waiting for other PR to be merged first.)