Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toHaveAccessibleErrorMessage to @testing-library/jest-dom Types #66089

Conversation

ITenthusiasm
Copy link
Contributor

@ITenthusiasm ITenthusiasm commented Jul 18, 2023

Will circle back to the checklist tomorrow.

Created in response to (and thus depends on):


Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes (see above)
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header. (Waiting for other PR to be merged first.)
    • New library version is mentioned in the JSDocs.

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Jul 18, 2023
@ITenthusiasm ITenthusiasm force-pushed the update-testing-library-assertions branch from ec4bf62 to 9c32d6e Compare July 18, 2023 12:09
@ITenthusiasm ITenthusiasm marked this pull request as ready for review July 18, 2023 12:14
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 18, 2023

@ITenthusiasm Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 66089,
  "author": "ITenthusiasm",
  "headCommitOid": "f58e2d708e347d4c167a2288d66cb1a75971a08f",
  "mergeBaseOid": "b0312dc15a45f047f9ad907cc9b32ea4d91c9037",
  "lastPushDate": "2023-07-18T01:38:50.000Z",
  "lastActivityDate": "2023-07-24T20:36:55.000Z",
  "mergeOfferDate": "2023-07-24T20:32:40.000Z",
  "mergeRequestDate": "2023-07-24T20:36:55.000Z",
  "mergeRequestUser": "ITenthusiasm",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "testing-library__jest-dom",
      "kind": "edit",
      "files": [
        {
          "path": "types/testing-library__jest-dom/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/testing-library__jest-dom/matchers.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/testing-library__jest-dom/test/testing-library__jest-dom-extend-matchers-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "gnapse",
        "jgoz",
        "smacpherson64",
        "AndrewLeedham"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2023-07-24T20:31:58.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "gnapse",
      "date": "2023-07-18T19:44:44.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "AndrewLeedham",
      "date": "2023-07-18T13:06:38.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1640102152,
  "ciResult": "pass"
}

@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board Jul 18, 2023
@typescript-bot
Copy link
Contributor

🔔 @gnapse @jgoz @smacpherson64 @AndrewLeedham — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jul 18, 2023
@ITenthusiasm ITenthusiasm force-pushed the update-testing-library-assertions branch from 9c32d6e to f58e2d7 Compare July 18, 2023 12:53
@typescript-bot typescript-bot removed the Owner Approved A listed owner of this package signed off on the pull request. label Jul 18, 2023
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Jul 18, 2023
@ITenthusiasm
Copy link
Contributor Author

@gnapse Updated the toHaveErrorMessage JSDoc to show the version at which the method was deprecated.

@typescript-bot
Copy link
Contributor

@gnapse Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jul 18, 2023
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jul 18, 2023
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jul 24, 2023
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Jul 24, 2023
@ITenthusiasm
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jul 24, 2023
@typescript-bot typescript-bot merged commit 4d6e7d5 into DefinitelyTyped:master Jul 24, 2023
2 checks passed
@ITenthusiasm ITenthusiasm deleted the update-testing-library-assertions branch July 24, 2023 20:38
@ITenthusiasm
Copy link
Contributor Author

Thanks all!

@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants