Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pg): add missing default configuration option #66684

Merged
merged 3 commits into from Oct 9, 2023
Merged

fix(pg): add missing default configuration option #66684

merged 3 commits into from Oct 9, 2023

Conversation

stuft2
Copy link
Contributor

@stuft2 stuft2 commented Sep 13, 2023

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 13, 2023

@stuft2 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 5 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 66684,
  "author": "stuft2",
  "headCommitOid": "b43e7eb01533407f24d4b092e511487ddbef8ed3",
  "mergeBaseOid": "e4dc6495cdfd9c29449bc91c01bfb9b9ab150f38",
  "lastPushDate": "2023-09-13T06:17:58.000Z",
  "lastActivityDate": "2023-10-09T17:24:23.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2023-10-03T23:00:12.000Z",
  "mergeRequestDate": "2023-10-09T17:24:23.000Z",
  "mergeRequestUser": "stuft2",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "pg",
      "kind": "edit",
      "files": [
        {
          "path": "types/pg/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/pg/pg-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "pspeter3",
        "HoldYourWaffle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2023-10-03T22:59:27.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "HoldYourWaffle",
      "date": "2023-09-14T15:27:02.000Z",
      "abbrOid": "56da145"
    }
  ],
  "mainBotCommentID": 1717013152,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels Sep 13, 2023
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Sep 13, 2023
@typescript-bot
Copy link
Contributor

🔔 @pspeter3 @HoldYourWaffle — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Sep 13, 2023
@stuft2
Copy link
Contributor Author

stuft2 commented Sep 14, 2023

Looks like this option was incorrectly specified in the types before, and it was rightly removed. #63690

Copy link
Contributor

@HoldYourWaffle HoldYourWaffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, double oversight. Makes total sense that a non-overridable "default option" should still be in the default options... (#63690 (review))

If you add this "new" option to the tests I'll approve this, thanks!

@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Sep 18, 2023
@typescript-bot
Copy link
Contributor

Re-ping @pspeter3, @HoldYourWaffle:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Sep 24, 2023
@HoldYourWaffle
Copy link
Contributor

@stuft2 If you add this option to the tests I'll approve it :)

@stuft2
Copy link
Contributor Author

stuft2 commented Sep 24, 2023

Sorry, I got held up with other work the past week. I think I have the tests written but I'll finish it up this week. 👍🏻

@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. and removed Untested Change This PR does not touch tests Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Sep 25, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Sep 25, 2023
@typescript-bot
Copy link
Contributor

@stuft2 Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@typescript-bot typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. labels Sep 25, 2023
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Sep 25, 2023
@typescript-bot
Copy link
Contributor

@HoldYourWaffle Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Oct 1, 2023
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @stuft2.

(Ping @pspeter3, @HoldYourWaffle.)

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 3, 2023
@typescript-bot typescript-bot removed the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Oct 3, 2023
@typescript-bot
Copy link
Contributor

@stuft2: Everything looks good here. I am ready to merge this PR (at b43e7eb) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@pspeter3, @HoldYourWaffle: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Oct 3, 2023
@stuft2
Copy link
Contributor Author

stuft2 commented Oct 9, 2023

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Oct 9, 2023
@typescript-bot typescript-bot merged commit f0cc246 into DefinitelyTyped:master Oct 9, 2023
2 checks passed
@stuft2 stuft2 deleted the patch-1 branch October 9, 2023 17:25
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants