New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pg): add missing default configuration option #66684
Conversation
@stuft2 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. InactiveThis PR has been inactive for 5 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66684,
"author": "stuft2",
"headCommitOid": "b43e7eb01533407f24d4b092e511487ddbef8ed3",
"mergeBaseOid": "e4dc6495cdfd9c29449bc91c01bfb9b9ab150f38",
"lastPushDate": "2023-09-13T06:17:58.000Z",
"lastActivityDate": "2023-10-09T17:24:23.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"mergeOfferDate": "2023-10-03T23:00:12.000Z",
"mergeRequestDate": "2023-10-09T17:24:23.000Z",
"mergeRequestUser": "stuft2",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "pg",
"kind": "edit",
"files": [
{
"path": "types/pg/index.d.ts",
"kind": "definition"
},
{
"path": "types/pg/pg-tests.ts",
"kind": "test"
}
],
"owners": [
"pspeter3",
"HoldYourWaffle"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2023-10-03T22:59:27.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "HoldYourWaffle",
"date": "2023-09-14T15:27:02.000Z",
"abbrOid": "56da145"
}
],
"mainBotCommentID": 1717013152,
"ciResult": "pass"
} |
🔔 @pspeter3 @HoldYourWaffle — please review this PR in the next few days. Be sure to explicitly select |
Looks like this option was incorrectly specified in the types before, and it was rightly removed. #63690 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, double oversight. Makes total sense that a non-overridable "default option" should still be in the default options... (#63690 (review))
If you add this "new" option to the tests I'll approve this, thanks!
Re-ping @pspeter3, @HoldYourWaffle: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
@stuft2 If you add this option to the tests I'll approve it :) |
Sorry, I got held up with other work the past week. I think I have the tests written but I'll finish it up this week. 👍🏻 |
@stuft2 Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
@HoldYourWaffle Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @stuft2. (Ping @pspeter3, @HoldYourWaffle.) |
@stuft2: Everything looks good here. I am ready to merge this PR (at b43e7eb) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@pspeter3, @HoldYourWaffle: you can do this too.) |
Ready to merge |
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: