[node] Update types to v18.18 #66750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semigradsky
force-pushed
the
node-18.18
branch
from
d98efc1
to
f1aebb5
Compare
Semigradsky
requested review from
eps1lon and
peterblazejewicz
as code owners
|
@Semigradsky Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66750,
"author": "Semigradsky",
"headCommitOid": "94939d7df90111ac50dcf20a69565f945c4c93eb",
"mergeBaseOid": "a40c3eebe42de18e2ba72036ecc9f79b74eaa6ef",
"lastPushDate": "2023-09-19T15:26:40.000Z",
"lastActivityDate": "2023-09-25T19:33:52.000Z",
"mergeOfferDate": "2023-09-25T19:28:40.000Z",
"mergeRequestDate": "2023-09-25T19:33:52.000Z",
"mergeRequestUser": "Semigradsky",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/child_process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/globals.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/child_process.ts",
"kind": "test"
},
{
"path": "types/node/v18/test/dgram.ts",
"kind": "test"
},
{
"path": "types/node/v18/test/events.ts",
"kind": "test"
},
{
"path": "types/node/v18/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v18/test/net.ts",
"kind": "test"
},
{
"path": "types/node/v18/test/stream.ts",
"kind": "test"
},
{
"path": "types/node/v18/test/test.ts",
"kind": "test"
},
{
"path": "types/node/v18/test/timers.ts",
"kind": "test"
},
{
"path": "types/node/v18/test/tls.ts",
"kind": "test"
},
{
"path": "types/node/v18/timers.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/child_process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/globals.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/node-tests.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/test/child_process.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/test/dgram.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/test/events.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/test/net.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/test/stream.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/test/test.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/test/timers.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/test/tls.ts",
"kind": "test"
},
{
"path": "types/node/v18/ts4.8/timers.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/ts4.8/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/url.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2023-09-25T19:27:56.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1733055371,
"ciResult": "pass"
} |
typescript-bot
added
Critical package
Author is Owner
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in New Pull Request Status Board
|
🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in New Pull Request Status Board
|
@Semigradsky The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Semigradsky
force-pushed
the
node-18.18
branch
from
f1aebb5
to
30f17f2
Compare
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in New Pull Request Status Board
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in New Pull Request Status Board
|
@Semigradsky The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
https://github.com/nodejs/node/releases/tag/v18.18.0 - child_process: support Symbol.dispose - dgram: socket add asyncDispose - events: allow safely adding listener to abortSignal - fs, stream: initial Symbol.dispose and Symbol.asyncDispose support - module: add SourceMap.findOrigin - net: server add asyncDispose - net: add autoSelectFamily global getter and setter - test_runner: fixed test shorthands return type - timers: support Symbol.dispose - url: add value argument to has and delete methods
Semigradsky
force-pushed
the
node-18.18
branch
from
30f17f2
to
94939d7
Compare
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in New Pull Request Status Board
typescript-bot
moved this from Waiting for Code Reviews
to Needs Maintainer Review
in New Pull Request Status Board
peterblazejewicz
approved these changes
Sep 25, 2023
typescript-bot
added
Maintainer Approved
Self Merge
typescript-bot
moved this from Needs Maintainer Review
to Waiting for Author to Merge
in New Pull Request Status Board
|
Ready to merge |
typescript-bot
moved this from Waiting for Author to Merge
to Recently Merged
in New Pull Request Status Board
AviVahl
reviewed
Sep 25, 2023
| function describe(name?: string, fn?: SuiteFn): void; | ||
| function describe(options?: TestOptions, fn?: SuiteFn): void; | ||
| function describe(fn?: SuiteFn): void; | ||
| function describe(name?: string, options?: TestOptions, fn?: SuiteFn): Promise<void>; |
There was a problem hiding this comment.
This caused our linter to start failing with @typescript-eslint/no-floating-promises, as nobody awaits the calls to describe/it. Furthermore, actually awaiting the it calls causes the second it to be delayed, which in-turn causes an error. For now, I've turned off that rule for test files, but ideally test files would be covered with that rule.
Example failure: https://github.com/wixplosives/sample-monorepo/actions/runs/6304680777/job/17116535127?pr=711
There was a problem hiding this comment.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nodejs/node/releases/tag/v18.18.0