Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pnpm to 8.15.0, improving CI partial install #68350

Merged
merged 1 commit into from Jan 29, 2024

Conversation

jakebailey
Copy link
Member

pnpm/pnpm#7563 is now released, which should reduce the likelihood that we need the workaround introduced in #67460. There are still PRs which will OOM and fall back to a full install, but partial installs should succeed more often.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 27, 2024

@jakebailey Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (package.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68350,
  "author": "jakebailey",
  "headCommitOid": "356bed9325dacb44815a4f7899aba0d04431d2c3",
  "mergeBaseOid": "75fea781e8326f14ae0b7b4822d0fb4bc2293088",
  "lastPushDate": "2024-01-27T20:43:07.000Z",
  "lastActivityDate": "2024-01-29T17:38:58.000Z",
  "mergeOfferDate": "2024-01-29T17:32:25.000Z",
  "mergeRequestDate": "2024-01-29T17:38:58.000Z",
  "mergeRequestUser": "jakebailey",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "package.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2024-01-29T17:31:44.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1913330780,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @jakebailey — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Jan 27, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jan 29, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Jan 29, 2024
@typescript-bot
Copy link
Contributor

@jakebailey: Everything looks good here. I am ready to merge this PR (at 356bed9) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@jakebailey
Copy link
Member Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jan 29, 2024
@typescript-bot typescript-bot merged commit d93dbc4 into DefinitelyTyped:master Jan 29, 2024
3 checks passed
@jakebailey jakebailey deleted the update-pnpm branch January 29, 2024 17:39
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Jan 29, 2024
andrewbranch pushed a commit to andrewbranch/DefinitelyTyped that referenced this pull request Jan 30, 2024
codershiba pushed a commit to codershiba/DefinitelyTyped that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants