Removal of import of `React` as it is no longer needed. #68395

ShivamKJJW · 2024-01-31T08:18:16Z

Reference to issue: 68394

react-native-video. Removal of React import as it is no more required. import from * is no more valid and provides ESlint error in latest react versions.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run pnpm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

Error screenshot:

typescript-bot · 2024-01-31T08:19:17Z

@ShivamKJJW Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

react-native-video — on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
❌ Continuous integration tests have failed
🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 68395,
  "author": "ShivamKJJW",
  "headCommitOid": "b1e122f31893bc92e8d822f349ca784e2e6be335",
  "mergeBaseOid": "6d0e970598392a8c1c62019150e4f197fadf301c",
  "lastPushDate": "2024-01-31T08:18:16.000Z",
  "lastActivityDate": "2024-01-31T17:42:49.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "react-native-video",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-native-video/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-native-video/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "huhuanming",
        "Nekith",
        "bananer"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1918604354,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/b1e122f31893bc92e8d822f349ca784e2e6be335/checks?check_suite_id=20294130726"
}

typescript-bot · 2024-01-31T08:19:19Z

Hey @ShivamKJJW,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

typescript-bot · 2024-01-31T08:19:20Z

🔔 @huhuanming @Nekith @bananer — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

ShivamKJJW · 2024-01-31T08:20:35Z

Hey @ShivamKJJW,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

It doesn't require any change in the test cases.

typescript-bot · 2024-01-31T08:21:58Z

@ShivamKJJW The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!