Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallabyjs] add new configuration options #68864

Conversation

boneskull
Copy link
Contributor

@boneskull boneskull commented Mar 1, 2024

This adds two new configuration options, as mentioned in https://github.com/wallabyjs/public/blob/518fb8df1b7f9076bfe5257a433aac0a94c3e48e/CHANGELOG.md\?plain\=1\#L394:

  • symlinkNodeModules
  • compactMessageOutput

In addition, I added missing properties in IWallabyWorkers. I added a test for these.

Please fill in this template.

If changing an existing definition:

This adds two new configuration options, as mentioned in https://github.com/wallabyjs/public/blob/518fb8df1b7f9076bfe5257a433aac0a94c3e48e/CHANGELOG.md\?plain\=1\#L394:

- `symlinkNodeModules`
- `compactMessageOutput`
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 1, 2024

@boneskull Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68864,
  "author": "boneskull",
  "headCommitOid": "c4e488695e6de0eecd515173632914c0f98cc43a",
  "mergeBaseOid": "1e70b911ff8c1ff74e1ea371115d267c0a383a93",
  "lastPushDate": "2024-03-01T21:28:18.000Z",
  "lastActivityDate": "2024-03-02T11:09:08.000Z",
  "mergeOfferDate": "2024-03-02T10:53:03.000Z",
  "mergeRequestDate": "2024-03-02T11:09:08.000Z",
  "mergeRequestUser": "andrewconnell",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "wallabyjs",
      "kind": "edit",
      "files": [
        {
          "path": "types/wallabyjs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wallabyjs/wallabyjs-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "andrewconnell",
        "boneskull"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewconnell",
      "date": "2024-03-02T10:52:21.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1973945670,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Mar 1, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Mar 1, 2024
@typescript-bot
Copy link
Contributor

🔔 @andrewconnell — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Mar 1, 2024
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Mar 1, 2024
@typescript-bot typescript-bot removed Owner Approved A listed owner of this package signed off on the pull request. Untested Change This PR does not touch tests labels Mar 1, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Mar 1, 2024
@boneskull
Copy link
Contributor Author

boneskull commented Mar 1, 2024

@andrewconnell Sorry, I noticed something else missing just now 😄

Please review again...

@DangerBotOSS
Copy link

DangerBotOSS commented Mar 1, 2024

Formatting

The following files are not formatted:

  1. types/wallabyjs/wallabyjs-tests.ts
  2. types/wallabyjs/index.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against c4e4886

@typescript-bot
Copy link
Contributor

@andrewconnell Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 2, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Mar 2, 2024
@typescript-bot
Copy link
Contributor

@boneskull: Everything looks good here. I am ready to merge this PR (at c4e4886) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@andrewconnell: you can do this too.)

@andrewconnell
Copy link
Contributor

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Mar 2, 2024
@typescript-bot typescript-bot merged commit 7592a3c into DefinitelyTyped:master Mar 2, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants