New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@types/selectize] Add types for missing methods #69378
base: master
Are you sure you want to change the base?
Conversation
@codershiba Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 31 days — it is still unreviewed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69378,
"author": "codershiba",
"headCommitOid": "59b331efad11cce2f8ae114371cbdd4de1a8eb06",
"mergeBaseOid": "895d2be48edd77037fb8920161d109059d600002",
"lastPushDate": "2024-04-17T10:44:15.000Z",
"lastActivityDate": "2024-05-06T17:17:14.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "selectize",
"kind": "edit",
"files": [
{
"path": "types/selectize/index.d.ts",
"kind": "definition"
}
],
"owners": [
"adidahiya",
"naBausch"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"mainBotCommentID": 2060967891,
"ciResult": "pass"
} |
Hey @codershiba, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
🔔 @adidahiya @naBausch — please review this PR in the next few days. Be sure to explicitly select |
@codershiba The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Re-ping @adidahiya, @naBausch: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @codershiba. (Ping @adidahiya, @naBausch.) |
As in the other PR, DT is at 0.12, and this package upstream is at 0.15; can you verify which versions things were added? |
Closes #69336
Closes #69377
Please fill in this template.
pnpm test selectize
.If changing an existing definition:
package.json
.