Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/stylis] Add SCOPE #69420

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

typicode
Copy link
Contributor

thysultan/stylis#329
released in v4.3.2

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Add @scope enum thysultan/stylis#329
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 23, 2024

@typicode Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer can merge changes when there are no other reviewers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69420,
  "author": "typicode",
  "headCommitOid": "9077770e0eab83ec6c6497c4e78d859c4f680d94",
  "mergeBaseOid": "9ec204164d296bac9574f8113417236cae2a5d62",
  "lastPushDate": "2024-04-23T15:09:16.000Z",
  "lastActivityDate": "2024-05-03T21:53:52.000Z",
  "mergeOfferDate": "2024-05-03T20:22:19.000Z",
  "mergeRequestDate": "2024-05-03T21:53:52.000Z",
  "mergeRequestUser": "typicode",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "stylis",
      "kind": "edit",
      "files": [
        {
          "path": "types/stylis/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2024-05-03T20:21:38.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2072634549,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package No Other Owners This DT module only has one owner, so we can't have someone verify the change. Untested Change This PR does not touch tests labels Apr 23, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Apr 23, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Apr 23, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 3, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board May 3, 2024
@typicode
Copy link
Contributor Author

typicode commented May 3, 2024

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 3, 2024
@typescript-bot typescript-bot merged commit ab34a47 into DefinitelyTyped:master May 3, 2024
4 checks passed
@typicode
Copy link
Contributor Author

typicode commented May 3, 2024

@rbuckton thank you!

@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved No Other Owners This DT module only has one owner, so we can't have someone verify the change. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants