-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@types/stylis] Add SCOPE #69420
[@types/stylis] Add SCOPE #69420
Conversation
thysultan/stylis#329 released in v4.3.2
@typicode Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69420,
"author": "typicode",
"headCommitOid": "9077770e0eab83ec6c6497c4e78d859c4f680d94",
"mergeBaseOid": "9ec204164d296bac9574f8113417236cae2a5d62",
"lastPushDate": "2024-04-23T15:09:16.000Z",
"lastActivityDate": "2024-05-03T21:53:52.000Z",
"mergeOfferDate": "2024-05-03T20:22:19.000Z",
"mergeRequestDate": "2024-05-03T21:53:52.000Z",
"mergeRequestUser": "typicode",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "stylis",
"kind": "edit",
"files": [
{
"path": "types/stylis/index.d.ts",
"kind": "definition"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2024-05-03T20:21:38.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2072634549,
"ciResult": "pass"
} |
Ready to merge |
@rbuckton thank you! |
thysultan/stylis#329
released in v4.3.2
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
package.json
.If removing a declaration:
notNeededPackages.json
.