Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README.es]: Update spanish doc and fix typos #69455

Merged
merged 3 commits into from May 7, 2024

Conversation

danielcuque
Copy link
Contributor

Please fill in this template.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 26, 2024

@danielcuque Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (README.es.md)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69455,
  "author": "danielcuque",
  "headCommitOid": "53033c036134e4d947f0bbd2629118dddea34c56",
  "mergeBaseOid": "2aee640d1a214803eae433df2620256ea02f2ec4",
  "lastPushDate": "2024-04-26T20:29:35.000Z",
  "lastActivityDate": "2024-05-07T00:53:45.000Z",
  "mergeOfferDate": "2024-05-06T17:09:32.000Z",
  "mergeRequestDate": "2024-05-07T00:53:45.000Z",
  "mergeRequestUser": "danielcuque",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "README.es.md",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2024-05-06T17:08:54.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2080077735,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @danielcuque — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@danielcuque danielcuque changed the title [docs]: Update spanish doc and fix typos [README-es]: Update spanish doc and fix typos Apr 26, 2024
@danielcuque danielcuque changed the title [README-es]: Update spanish doc and fix typos [README.es]: Update spanish doc and fix typos Apr 26, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Apr 26, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in New Pull Request Status Board Apr 26, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Apr 26, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in New Pull Request Status Board Apr 26, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Apr 26, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 6, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board May 6, 2024
@typescript-bot
Copy link
Contributor

@danielcuque: Everything looks good here. I am ready to merge this PR (at 53033c0) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@danielcuque
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 7, 2024
@typescript-bot typescript-bot merged commit 64828b6 into DefinitelyTyped:master May 7, 2024
5 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants