Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[office-js][office-js-preview] (Outlook) Document Mailbox 1.14 #69482

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

samantharamon
Copy link
Contributor

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: None.
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 14, 2024

@samantharamon Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 17 days — please try to get reviewers!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69482,
  "author": "samantharamon",
  "headCommitOid": "d5f8b776cb6825b6e59bf7af06f6721134b12aad",
  "mergeBaseOid": "45d34da16d9556b29be0469dbb66337735690feb",
  "lastPushDate": "2024-05-01T05:35:13.000Z",
  "lastActivityDate": "2024-05-15T20:44:02.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "office-js-preview",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js-preview/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "office-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "jakebailey",
      "date": "2024-05-15T20:44:02.000Z",
      "abbrOid": "1c8400a"
    },
    {
      "type": "stale",
      "reviewer": "ElizabethSamuel-MSFT",
      "date": "2024-05-15T20:35:21.000Z",
      "abbrOid": "1c8400a"
    },
    {
      "type": "stale",
      "reviewer": "Rick-Kirkham",
      "date": "2024-05-15T02:22:41.000Z",
      "abbrOid": "75a5969"
    }
  ],
  "mainBotCommentID": 2111030591,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 14, 2024
@typescript-bot
Copy link
Contributor

Hey @samantharamon,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board May 14, 2024
@typescript-bot
Copy link
Contributor

🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @alison-mk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 14, 2024

Re-ping @OfficeDev, @Rick-Kirkham, @AlexJerabek, @ElizabethSamuel-MSFT, @alison-mk:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 14, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in New Pull Request Status Board May 14, 2024
@typescript-bot
Copy link
Contributor

@samantharamon One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed Revision needed This PR needs code changes before it can be merged. labels May 15, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board May 15, 2024
@typescript-bot
Copy link
Contributor

@Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Waiting for Code Reviews in New Pull Request Status Board May 15, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 15, 2024
@typescript-bot
Copy link
Contributor

@jakebailey, @Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

types/office-js/index.d.ts Outdated Show resolved Hide resolved
types/office-js/index.d.ts Show resolved Hide resolved
types/office-js-preview/index.d.ts Show resolved Hide resolved
types/office-js-preview/index.d.ts Show resolved Hide resolved
types/office-js-preview/index.d.ts Show resolved Hide resolved
types/office-js/index.d.ts Show resolved Hide resolved
types/office-js/index.d.ts Show resolved Hide resolved
types/office-js/index.d.ts Show resolved Hide resolved
types/office-js/index.d.ts Show resolved Hide resolved
types/office-js/index.d.ts Show resolved Hide resolved
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board May 15, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 15, 2024
@typescript-bot
Copy link
Contributor

@ElizabethSamuel-MSFT, @jakebailey, @Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 15, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 15, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board May 15, 2024
@typescript-bot
Copy link
Contributor

@Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed Self Merge This PR can now be self-merged by the PR author or an owner Owner Approved A listed owner of this package signed off on the pull request. Maintainer Approved labels May 15, 2024
@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Waiting for Code Reviews in New Pull Request Status Board May 15, 2024
@typescript-bot
Copy link
Contributor

@jakebailey, @ElizabethSamuel-MSFT, @Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 15, 2024
@typescript-bot typescript-bot added the Where is GH Actions? GH Actions didn't give a response to this PR label May 15, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Other in New Pull Request Status Board May 15, 2024
@typescript-bot typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label May 15, 2024
@typescript-bot typescript-bot moved this from Other to Needs Maintainer Review in New Pull Request Status Board May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Edits multiple packages Popular package This PR affects a popular package (as counted by NPM download counts). Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. Untested Change This PR does not touch tests
Projects
New Pull Request Status Board
Needs Maintainer Review
Development

Successfully merging this pull request may close these issues.

None yet

5 participants