New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[office-js][office-js-preview] (Outlook) Document Mailbox 1.14 #69482
base: master
Are you sure you want to change the base?
[office-js][office-js-preview] (Outlook) Document Mailbox 1.14 #69482
Conversation
@samantharamon Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PR
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 17 days — please try to get reviewers! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69482,
"author": "samantharamon",
"headCommitOid": "d5f8b776cb6825b6e59bf7af06f6721134b12aad",
"mergeBaseOid": "45d34da16d9556b29be0469dbb66337735690feb",
"lastPushDate": "2024-05-01T05:35:13.000Z",
"lastActivityDate": "2024-05-15T20:44:02.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "office-js-preview",
"kind": "edit",
"files": [
{
"path": "types/office-js-preview/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "office-js",
"kind": "edit",
"files": [
{
"path": "types/office-js/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "jakebailey",
"date": "2024-05-15T20:44:02.000Z",
"abbrOid": "1c8400a"
},
{
"type": "stale",
"reviewer": "ElizabethSamuel-MSFT",
"date": "2024-05-15T20:35:21.000Z",
"abbrOid": "1c8400a"
},
{
"type": "stale",
"reviewer": "Rick-Kirkham",
"date": "2024-05-15T02:22:41.000Z",
"abbrOid": "75a5969"
}
],
"mainBotCommentID": 2111030591,
"ciResult": "pass"
} |
Hey @samantharamon, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @alison-mk — please review this PR in the next few days. Be sure to explicitly select |
Re-ping @OfficeDev, @Rick-Kirkham, @AlexJerabek, @ElizabethSamuel-MSFT, @alison-mk: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
@samantharamon One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
@Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@jakebailey, @Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@ElizabethSamuel-MSFT, @jakebailey, @Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@jakebailey, @ElizabethSamuel-MSFT, @Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
pnpm test <package to test>
.If changing an existing definition:
package.json
.