Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[relay-runtime] return undefined from readInlineFragment #69622

Merged
merged 1 commit into from
May 16, 2024

Conversation

robrichard
Copy link
Contributor

Same change was done to useFragment here: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67136/files

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@robrichard robrichard requested a review from alloy as a code owner May 16, 2024 18:10
@typescript-bot
Copy link
Contributor

typescript-bot commented May 16, 2024

@robrichard Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69622,
  "author": "robrichard",
  "headCommitOid": "4d1ef3c4a062143ee27ab2bb7d6aa676cb2cf99c",
  "mergeBaseOid": "50f363161dbe42cabc3ee949bf3d6c47e67a93bf",
  "lastPushDate": "2024-05-16T18:10:07.000Z",
  "lastActivityDate": "2024-05-16T18:10:07.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "relay-runtime",
      "kind": "edit",
      "files": [
        {
          "path": "types/relay-runtime/lib/store/readInlineData.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "alloy",
        "maraisr",
        "morrys",
        "levibuzolic"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2115896250,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels May 16, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 16, 2024
@typescript-bot
Copy link
Contributor

🔔 @alloy @maraisr @morrys @levibuzolic — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 16, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board May 16, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 16, 2024
@alloy alloy merged commit f1525a2 into DefinitelyTyped:master May 16, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board May 16, 2024
@robrichard robrichard deleted the robrichard/readInlineData branch May 17, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants