Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use pep517/pep621 #1140

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

build: use pep517/pep621 #1140

wants to merge 13 commits into from

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented May 13, 2024

replace legacy setup.py with pyproject.toml pep517/pep621 config

@Delgan
Copy link
Owner

Delgan commented May 16, 2024

Thank you for modernizing the project @trim21!

I've made a few fix to the CI runners, can you try rebasing your PR please? However, I do not explain the failure for Python 3.6.

@trim21
Copy link
Contributor Author

trim21 commented May 16, 2024

Thank you for modernizing the project @trim21!

I've made a few fix to the CI runners, can you try rebasing your PR please? However, I do not explain the failure for Python 3.6.

would you mind enable this option in repo settings? so I can update branch in web-ui instead of local git client.

image

@Delgan
Copy link
Owner

Delgan commented May 16, 2024

would you mind enable this option in repo settings? so I can update branch in web-ui instead of local git client.

Done, thanks for the suggestion. 👍

@trim21
Copy link
Contributor Author

trim21 commented May 16, 2024

I guess, ci failed because setuptools support python3.5/3.6 are very out-dated and doesn't support new feature we are using.

@trim21
Copy link
Contributor Author

trim21 commented May 16, 2024

at fitst I want to continue using setuptools but python3.5/3.6 are too old and setuptools support theee 2 versions missing some feature we need and doesn't have a full support for pep621.

So I have to use flit to make it work on these 2 versions.

If you want to continue using setuptools we need drop these 2 python versions first.

@trim21 trim21 changed the title build: use pep517 build: use pep517/pep621 May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants