Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude internal components from policy evaluation, fixes #2145 #3321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabian-zeindl-oebb
Copy link

@fabian-zeindl-oebb fabian-zeindl-oebb commented Dec 18, 2023

Description

Don't match internal components for policy evaluation.

Addressed Issue

#2145

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@fabian-zeindl-oebb
Copy link
Author

Unfortunaely I could not fix the tests because I keep getting this error-message when I run them in intellij:

javax.jdo.JDOFatalUserException: A property named javax.jdo.PersistenceManagerFactoryClass must be specified, or a jar file with a META-INF/services/javax.jdo.PersistenceManagerFactory entry must be in the classpath, or a property named javax.jdo.option.PersistenceUnitName must be specified.

@rkg-mm
Copy link
Contributor

rkg-mm commented Dec 18, 2023

"Only match internal components for policy evaluation."
You mean only NOT internal, or?

The error You mention I saw too, just try running the "Build API" task a second time before running any tests, then it works for me, sometimes running a 3rd time is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants