-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add project name and group to bomupload logs #3690
Conversation
Signed-off-by: Ross Murphy <RossMurphy@ibm.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
I like this specific addition, but on a larger scale it might be better to setup a proper MDC so we can log the User or Team Principal for all log messages? (If the Alpine logging wrapper supports that or can be removed) https://medium.com/javarevisited/mapped-diagnostic-context-mdc-6447b598736d |
It does, and I added the MDC context to the default logback config in v4.11. The new BOM processing task makes use of MDC already, and we're planning to adopt it in more areas: dependency-track/src/main/java/org/dependencytrack/tasks/BomUploadProcessingTask.java Lines 147 to 153 in db58e69
For Alpine specifically, I recently added We could do the same for |
@nscuro I'd need to get permission to contribute to Alpine, so feel free to close this PR if thats the preferred approach |
Description
Currently there is no logs printed to display which group is creating the new project when uploading a bom using curl.
This change finds the group associated with the api-key and prints it in the logs along with the project name.
Addressed Issue
closes #3642
Checklist