Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ingestion of CycloneDX v1.6 BOMs #3710

Merged
merged 1 commit into from
May 15, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 15, 2024

Description

Adds support for ingestion of CycloneDX v1.6 BOMs.

  • Updates cyclonedx-core-java to version 9.0.0
  • Bumps Jackson to version 2.17.1 to resolve compatibility issues with cyclonedx-core-java
  • Resolve various compilation errors due to refactoring in cyclonedx-core-java
  • Add validator tests for all CycloneDX versions

Note

BOM exports will continue to use v1.5 for the time being. This avoids breaking users' workflows in case their tooling doesn't yet support v1.6.

Addressed Issue

Closes #3584

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added enhancement New feature or request cdx-1.6 Related to CycloneDX specification v1.6 labels May 15, 2024
@nscuro nscuro added this to the 4.12 milestone May 15, 2024
@nscuro nscuro mentioned this pull request May 15, 2024
2 tasks
* Updates `cyclonedx-core-java` to version `9.0.0`
* Bumps Jackson to version `2.17.1` to resolve compatibility issues with `cyclonedx-core-java`
* Resolve various compilation errors due to refactoring in `cyclonedx-core-java`
* Add validator tests for all CycloneDX versions

Note that BOM exports will continue to use v1.5 for the time being. This avoids breaking users' workflows in case their tooling doesn't yet support v1.6.

Closes DependencyTrack#3584

Signed-off-by: nscuro <nscuro@protonmail.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 78.95% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (21115d3) 22051 16753 75.97%
Head commit (c97bb54) 22056 (+5) 16763 (+10) 76.00% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3710) 19 15 78.95%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro merged commit b221329 into DependencyTrack:master May 15, 2024
12 checks passed
@nscuro nscuro deleted the issue-3584 branch May 15, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cdx-1.6 Related to CycloneDX specification v1.6 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Import of CycloneDX 1.6 BOMs
1 participant