Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Return processing token when cloning project #659

Merged
merged 3 commits into from
May 21, 2024

Conversation

leec94
Copy link
Contributor

@leec94 leec94 commented Apr 25, 2024

Description

Porting feature Return processing token when cloning project: DependencyTrack/dependency-track#3260

Addressed Issue

Porting features from v4.11, working on overall issue: DependencyTrack/hyades#1190

Additional Details

Haven't run any specific tests on this, if CI tests are not sufficient let me know and I can look into what testing was done for this too.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leec94!

When porting code from other contributors, can you please include Co-Authored-By in the commit message, so their work is being credited in the Git history?

Instructions here: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

Signed-off-by: leec94 <leec94@bu.edu>
Co-authored-by: Ralf King <rkg@mm-software.com>
@leec94 leec94 force-pushed the issue-3260-processingtoken branch from a7142b5 to 9cc34ee Compare April 26, 2024 13:15
@leec94
Copy link
Contributor Author

leec94 commented Apr 26, 2024

thanks for the tip @nscuro , i amended the commit with the original committer as a coauthor. lmk if anything else needs changing!

Co-authored-by: leec94 <leec94@bu.edu>
Signed-off-by: leec94 <leec94@bu.edu>
@nscuro nscuro added the v4-port PRs that were ported from the Dependency-Track v4.x code base label Apr 29, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 37.50% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (01c3387) 18050 14447 80.04%
Head commit (3799e52) 18057 (+7) 14452 (+5) 80.04% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#659) 8 3 37.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro added this to the 5.5.0 milestone May 21, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leec94!

@nscuro nscuro changed the title porting feature from issue-3260 Port: Return processing token when cloning project May 21, 2024
@nscuro nscuro merged commit 63e1aa0 into DependencyTrack:main May 21, 2024
8 of 10 checks passed
@leec94 leec94 deleted the issue-3260-processingtoken branch May 21, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
2 participants