Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Jersey TestContainer once per class vs. once per test method #670

Merged
merged 1 commit into from
May 21, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 2, 2024

Description

Starts the Jersey TestContainer once per class vs. once per test method.

Reduces the time it takes to execute the entire test suite, since the Jersey context is not torn down and rebuilt from scratch as often.

Addressed Issue

Ports DependencyTrack/dependency-track#3668

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added dx Issues related to developer experience (DX) v4-port PRs that were ported from the Dependency-Track v4.x code base labels May 2, 2024
Copy link

codacy-production bot commented May 2, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e188d99) 18050 14447 80.04%
Head commit (0a7e24b) 18050 (+0) 14445 (-2) 80.03% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#670) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro
Copy link
Member Author

nscuro commented May 3, 2024

In DependencyTrack/dependency-track#3668 it shaved off 10min of test execution time (30min -> 20min). Here it appears to be 15min (last main build took ~48min, the build for this PR took ~32min)!

Copy link
Collaborator

@sahibamittal sahibamittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sahibamittal sahibamittal merged commit b5a2215 into main May 21, 2024
10 checks passed
@sahibamittal sahibamittal deleted the port-pr-3668 branch May 21, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Issues related to developer experience (DX) v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
2 participants