Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off auto-optimize-store on Linux #567

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Turn off auto-optimize-store on Linux #567

wants to merge 2 commits into from

Conversation

Hoverbear
Copy link
Contributor

Description

Closes #564

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added this to the 0.10.1 milestone Jul 13, 2023
@Hoverbear Hoverbear requested a review from cole-h July 13, 2023 17:39
@Hoverbear Hoverbear self-assigned this Jul 13, 2023
@Hoverbear Hoverbear marked this pull request as ready for review July 13, 2023 17:39
cole-h
cole-h previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shame :(

@Hoverbear Hoverbear force-pushed the hoverbear/ds-1004-consider-turning-off-auto-optimize-store-on-linux-too branch from 33ae791 to b49a4df Compare July 13, 2023 20:26
@cole-h cole-h self-requested a review July 14, 2023 15:13
@cole-h cole-h dismissed their stale review July 14, 2023 15:13

we want to know why the slowdowns are happening before we actually disable it

@Hoverbear Hoverbear modified the milestones: 0.11.0, 0.11.1 Aug 10, 2023
@Hoverbear Hoverbear removed this from the 0.11.1 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h Awaiting requested review from cole-h

At least 1 approving review is required to merge this pull request.

Assignees

@Hoverbear Hoverbear

Labels
Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider turning off auto-optimise-store on Linux too
2 participants
@Hoverbear @cole-h