Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NavSprite): Repetitive dependency injection and supplementary notes #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(NavSprite): Repetitive dependency injection and supplementary notes #150

wants to merge 1 commit into from

Conversation

flxy1028
Copy link

依赖重复和少注释

Simplelegant
Simplelegant reviewed May 12, 2022
View reviewed changes
devui/nav-sprite/nav-sprite.component.ts
private cdr: ChangeDetectorRef,
@Inject(DOCUMENT) private doc: any
@Inject(DOCUMENT) private document: Document
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

构建会有报错，建议将document类型暂时修改为any或采用其它更好解决方式
image

Copy link
Member

@kagol kagol Aug 2, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

构建会有报错，建议将document类型暂时修改为any或采用其它更好解决方式 image

@Simplelegant 可以考虑将构建加到PR门禁里，这样PR的作者能够立即知道他自己提交的PR是否能通过构建任务，参考vue-devui的：
pull-request.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simplelegant Simplelegant Simplelegant left review comments

@kagol kagol kagol approved these changes

@xiejay97 xiejay97 xiejay97 approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flxy1028 @Simplelegant @kagol @xiejay97