Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: patch nx js package to avoid adding devDependencies #514

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

ajwootto
Copy link
Contributor

Temporarily patch the @nx/js package using yarn patch to fix the bug where Nx is adding devDependencies to dependencies, breaking our build.

The issue is described here:
nrwl/nx#17758

For a diff with the changes being applied in the patch, see this Nx PR:
nrwl/nx#17802

@ajwootto ajwootto requested a review from a team June 27, 2023 17:00
@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-sdks-next-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 5:06pm
js-sdks-web-elements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 5:06pm
js-sdks-with-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 5:06pm

@ajwootto ajwootto merged commit e092876 into main Jun 27, 2023
13 of 14 checks passed
@ajwootto ajwootto deleted the DVC-7977-patch-js-paackge branch June 27, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants