Use polyfill if location.origin doesn't exist (in IE11)
#2441
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @danielroe Thank you for contributing to 'testcafe-hammerhead'. We will review your PR at the start of the next sprint because the current sprint is already planned. |
|
@testcafe-build-bot retest |
|
Thank you for the contributing. |
AlexSkorkin
added a commit
to DevExpress/testcafe
that referenced
this pull request
Dec 9, 2020
[AlexanderMoiseev](https://github.com/AlexanderMoiseev) [augustomezencio-hotmart](https://github.com/augustomezencio-hotmart) - [Fix tree-kill vulnerability from old version.](#5690) [bdwain](https://github.com/bdwain) - [Fixes header types for request and response mocks (#5529)](#5530) [mostlyfabulous](https://github.com/mostlyfabulous) - [Gh2172 Add `ShadowRoot()` as a chainable Selector method](#5560) [danielroe](https://github.com/danielroe) - [Use polyfill if `location.origin` doesn't exist (in IE11)](DevExpress/testcafe-hammerhead#2441)
2 tasks
testcafe-build-bot
added a commit
to testcafe-build-bot/testcafe
that referenced
this pull request
Dec 9, 2020
[AlexanderMoiseev](https://github.com/AlexanderMoiseev) [augustomezencio-hotmart](https://github.com/augustomezencio-hotmart) - [Fix tree-kill vulnerability from old version.](DevExpress#5690) [bdwain](https://github.com/bdwain) - [Fixes header types for request and response mocks (DevExpress#5529)](DevExpress#5530) [mostlyfabulous](https://github.com/mostlyfabulous) - [Gh2172 Add `ShadowRoot()` as a chainable Selector method](DevExpress#5560) [danielroe](https://github.com/danielroe) - [Use polyfill if `location.origin` doesn't exist (in IE11)](DevExpress/testcafe-hammerhead#2441)
testcafe-build-bot
added a commit
to testcafe-build-bot/testcafe
that referenced
this pull request
Dec 9, 2020
[AlexanderMoiseev](https://github.com/AlexanderMoiseev) [augustomezencio-hotmart](https://github.com/augustomezencio-hotmart) - [Fix tree-kill vulnerability from old version.](DevExpress#5690) [bdwain](https://github.com/bdwain) - [Fixes header types for request and response mocks (DevExpress#5529)](DevExpress#5530) [mostlyfabulous](https://github.com/mostlyfabulous) - [Gh2172 Add `ShadowRoot()` as a chainable Selector method](DevExpress#5560) [danielroe](https://github.com/danielroe) - [Use polyfill if `location.origin` doesn't exist (in IE11)](DevExpress/testcafe-hammerhead#2441)
AndreyBelym
pushed a commit
to DevExpress/testcafe
that referenced
this pull request
Dec 11, 2020
[AlexanderMoiseev](https://github.com/AlexanderMoiseev) [augustomezencio-hotmart](https://github.com/augustomezencio-hotmart) - [Fix tree-kill vulnerability from old version.](#5690) [bdwain](https://github.com/bdwain) - [Fixes header types for request and response mocks (#5529)](#5530) [mostlyfabulous](https://github.com/mostlyfabulous) - [Gh2172 Add `ShadowRoot()` as a chainable Selector method](#5560) [danielroe](https://github.com/danielroe) - [Use polyfill if `location.origin` doesn't exist (in IE11)](DevExpress/testcafe-hammerhead#2441)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To prevent IE11 from crashing where web workers are being used.
Approach
This polyfills
location.originwithlocation.protocol + "//" + location.hostin environments withoutlocation.origin(like IE11 under the Intranet Zone).References
closes #2440
Pre-Merge TODO