Skip to content

Fix document.title processing for iframes #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2020
Merged

Fix document.title processing for iframes #2451

merged 2 commits into from
Sep 25, 2020
+75 −47

Conversation

miherlosev
Copy link
Contributor

@miherlosev miherlosev commented Sep 23, 2020 •
edited
Loading

Changes:

  • fix insertion order for the addPageOriginFirstTitleParsedScript self removing script in iframes
  • proxy document.title only for top window.
  • tests here

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 40832cc have failed. See details.

@miherlosev
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 40832cc have passed. See details.

@miherlosev miherlosev marked this pull request as ready for review September 25, 2020 05:20
@miherlosev miherlosev merged commit 0160277 into DevExpress:master Sep 25, 2020
@miherlosev miherlosev deleted the sandbox_document_title_only_for_top_window branch September 25, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LavrovArtem LavrovArtem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miherlosev @testcafe-build-bot @LavrovArtem