fix: session referer rewritten in iframe tasks #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naggingant
force-pushed
the
fix/gh7376
branch
from
a39c8c3
to
a135ca7
Compare
Aleksey28
requested changes
Nov 11, 2022
src/proxy/index.ts
Outdated
| @@ -211,7 +211,7 @@ export default class Proxy extends Router { | |||
| const windowId = refererDest && refererDest.windowId || void 0; | |||
|
|
|||
| if (session) { | |||
| session.options.referer = referer || session.options.referer; | |||
| if (!isIframe) session.options.referer = referer || session.options.referer; | |||
There was a problem hiding this comment.
I suggest you do this as follows:
Suggested change
| if (!isIframe) session.options.referer = referer || session.options.referer; | |
| if (!isIframe && referer) | |
| session.options.referer = referer; |
There was a problem hiding this comment.
Sounds good, thanks
naggingant
force-pushed
the
fix/gh7376
branch
from
a135ca7
to
c11b335
Compare
|
Applied the suggestion. Thank you for the prompt response! |
Aleksey28
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DevExpress/testcafe#7376
Purpose
This partially undoes 55209a5 so that the session referer option does not get rewritten by iframe tasks.
Approach
I simply added the condition before this rewrite happens, but I am not familiar enough with the codebase nor proxies in general to fully justify the change.
Let me know if it makes sense as well as the test. I can close it otherwise.
References
DevExpress/testcafe#7376
Pre-Merge TODO