Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed getSelectElementSize #2815

Merged
merged 1 commit into from Nov 23, 2022
Merged

fix: fixed getSelectElementSize #2815

merged 1 commit into from Nov 23, 2022

Conversation

Aleksey28
Copy link
Collaborator

Upgrade getSelectElementSize function

Purpose

When a select has the attribute multiple it should check for the existence of the attribute, not its value.

Approach

  1. Replace getAttribute to hasAttribute
  2. Fix test

References

Provide a link to the existing issue(s), if any.

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Aleksey28 Aleksey28 temporarily deployed to CI November 23, 2022 08:56 Inactive
@Aleksey28 Aleksey28 self-assigned this Nov 23, 2022
@AndreyBelym AndreyBelym merged commit fb3d4d3 into DevExpress:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyBelym AndreyBelym AndreyBelym approved these changes

Assignees

@Aleksey28 Aleksey28

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aleksey28 @AndreyBelym