Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed cookie synchronization #2818

Merged
merged 6 commits into from Dec 16, 2022

Conversation

Aleksey28
Copy link
Collaborator

@Aleksey28 Aleksey28 commented Dec 8, 2022

Purpose

The cookies weren't synchronized correctly. It needs to be fixed.

Approach

  1. Add test
  2. Research problem
  3. Fix

References

https://stackoverflow.com/questions/74684772/deleted-cookies-arent-deleted-properly-and-still-sent-with-requests

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Aleksey28 Aleksey28 temporarily deployed to CI December 8, 2022 09:58 — with GitHub Actions Inactive
src/utils/cookie.ts Outdated Show resolved Hide resolved
@Aleksey28 Aleksey28 temporarily deployed to CI December 8, 2022 10:58 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI December 8, 2022 11:18 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI December 8, 2022 13:04 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 temporarily deployed to CI December 8, 2022 17:31 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 marked this pull request as draft December 8, 2022 18:19
@Aleksey28 Aleksey28 temporarily deployed to CI December 8, 2022 18:33 — with GitHub Actions Inactive
@Aleksey28 Aleksey28 marked this pull request as ready for review December 9, 2022 05:52
@Aleksey28 Aleksey28 self-assigned this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants