Fix null window case in _getCurrentInfoManager() #2936
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a fix for an issue reported in DevExpress/testcafe#7886. You can find the stacktrace there.
Approach
I do not know if this is the correct approach but it is logical and it fixes the problem. I tested it by editing hammerhead.js directly in our vendor folder.
The reasoning: The use case here is when
contextWindow
value is undefined what makes no need to callgetSandboxBackup()
.getSandboxBackup()
akaget()
called at the bottom of_getCurrentInfoManager()
function may returnnull
according totestcafe-hammerhead/src/client/sandbox/backup.ts
Lines 44 to 56 in 6607246
I cannot add unit tests as my knowledge of hammerhead is very limited.
Debug for the context:
References
DevExpress/testcafe#7886
Pre-Merge TODO